Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI to create flattened composite images #46

Merged
merged 17 commits into from
Sep 27, 2024
Merged

Add CLI to create flattened composite images #46

merged 17 commits into from
Sep 27, 2024

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Sep 4, 2024

Adds an additional command line interface to allow users to manually merge grayscale images from different colour channels in a dataset to create a composite image.

This pull request introduces the minimum features needed in order to create such a composite. More features will be added in future pull requests.

@tieneupin tieneupin self-assigned this Sep 4, 2024
@tieneupin tieneupin added the enhancement New feature or request label Sep 4, 2024
@tieneupin tieneupin marked this pull request as ready for review September 17, 2024 16:15
@tieneupin tieneupin changed the title Add CLIs to create flattened composite images Add CLI to create flattened composite images Sep 24, 2024
@tieneupin
Copy link
Contributor Author

tieneupin commented Sep 24, 2024

@d-j-hatton , @stephen-riggs , I've tested the CLI with flatten both enabled and disabled, and it successfully produces 2D and 3D images. Currently, it can run into memory allocation issues when flatten is disabled due to the size of the stacks we're dealing with, so it might be worth considering packaging it for users as a cluster job instead.

@tieneupin
Copy link
Contributor Author

tieneupin commented Sep 26, 2024

Validation tests done:

  • clem.lif_to_stack CLI works
  • clem.tiff_to_stack CLI works
  • Cluster submission of LIF processing job works
  • Cluster submission of TIFF processing job works
  • clem.process_stacks CLI works

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 318 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@cc7c6a4). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage        ?   45.22%           
=======================================
  Files           ?       42           
  Lines           ?     5860           
  Branches        ?     1044           
=======================================
  Hits            ?     2650           
  Misses          ?     2890           
  Partials        ?      320           

@tieneupin tieneupin merged commit 774fbe0 into main Sep 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command line entry points to create flattened colored images of CLEM image stacks
3 participants