Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimas (+Trigger) #129

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

stufisher
Copy link
Contributor

An extracted version of Mimas which uses a local package to define what actual choices to make rather than hard coding decisions in the core source code. The trigger service is in here as well as it shares the same cookiecutter implementors package so is relevant.

Mostly a direct copy paste from dlstbx, with a few additions to the mimas class to extract things like dcg.experimentType and other useful things for none mx decision making. I will try to do a more recent diff between this and dlstbx to check for any other changes.

Does not yet include a backlog processor as the current code is extremely dls specific.

@rjgildea
Copy link
Contributor

rjgildea commented Oct 4, 2021

I recently merged in some fairly significant changes to the DLSTrigger service in https://github.com/DiamondLightSource/python-dlstbx/pull/89 affecting how the parameters are passed to each trigger function and how they are validated. It would be good if this could be compatible with those changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants