force utf8 to save config. #378
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find that every time I restart the server after saving the Chinese configuration file, the configuration file will be garbled. That may be because the configuration file in the jar is utf8, and the platform encode is other, when the plugin saves the default configuration file, it will save utf8 as other encodes.
I thought of two solutions: one is to force the configuration file to be saved in utf8 instead of platform encode; or to read the configuration file in the jar and save it as the platform encode, so that the encode in all places is the platform encode.
This pull request is the first way, i think force utf8 is better than use platform encode, but I also used the second solution in my other branch, if you don't like utf8 then you can consider this.