Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopper-distillery compatibility #598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Thorinwasher
Copy link

Current situation

Whenever a brewing potion has been inserted into a distillery using hoppers, the item is there, but no distilling is initiated.

What these changes do

Applies the same checks that are done whenever a player takes/removes an item from the distillery to hoppers moving/removing items.

  • Should not increase the lag that much (if any), as most of the code is hidden behind type checks; Only hopper movement of potions into and from distilleries are considered.
  • I would not say this breaks immersion, as one can already insert the potion into the distiller; keeping it as is does not make any sense as the item can be inside of the distiller without initiating a distill run.

I can add an option for this, if that's deemed necessary.

Jsinco referenced this pull request in BreweryTeam/BreweryX Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant