Merge pull request #180 from DigiKlausur/fix_remove_shortcuts

Fix remove shortcuts
DigiKlausur · Mar 15, 2024 · 339f527 · 339f527
2 parents e3877fc + eaea3e8
commit 339f527
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 68 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/restricted-exam-notebook/src/disable-shortcuts.js b/packages/restricted-exam-notebook/src/disable-shortcuts.js
@@ -18,12 +18,16 @@ export function disable_shortcuts() {
     "d,d",
   ];
 
-  utils.remove_shortcuts("command", shortcuts);
-  utils.remove_shortcuts("edit", shortcuts);
+  const modes = ["command", "edit"];
+
+  for (let mode of modes) {
+    utils.remove_shortcuts(mode, ...shortcuts);
+  }
 
   utils.remove_shortcuts("command", "crtl-v");
 
   utils.disable_add_cell_on_execute();
+
   utils.add_shortcut(
     "command",
     "ctrl-v",

diff --git a/packages/utils/src/shortcuts.js b/packages/utils/src/shortcuts.js
@@ -53,6 +53,14 @@ export function remove_shortcuts(mode, ...shortcuts) {
     try {
       manager.remove_shortcut(shortcut);
     } catch (e) {
+      console.log(
+        "Error removing shortcut",
+        shortcut,
+        "from",
+        mode,
+        "mode:",
+        e.message
+      );
       // Shortcut does not exist and can't be removed;
     }
   }
@@ -83,8 +91,8 @@ export function add_shortcut(mode, key, handler, help, help_index = "zz") {
 export function disable_add_cell_on_execute() {
   add_Notebook_execute_cell_and_select();
   const shortcut_keys = ["alt-enter", "shift-enter"];
-  remove_shortcuts("edit", shortcut_keys);
-  remove_shortcuts("command", shortcut_keys);
+  remove_shortcuts("edit", ...shortcut_keys);
+  remove_shortcuts("command", ...shortcut_keys);
 
   const help = "run cell";
   const handler = function (event) {