Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

Conda Package plus streamlining #767

Closed
wants to merge 4 commits into from
Closed

Conda Package plus streamlining #767

wants to merge 4 commits into from

Conversation

drwelby
Copy link
Contributor

@drwelby drwelby commented Jun 5, 2019

0.16.7 was supposed to be the last '16 release but in fixing up the Conda packaging I made enough changes to warrant a new release.

  • New meta.yaml built from conda skeleton and then edited down
  • Dropping 3.4 support since it's EOLed
  • 3.7 seems to work
  • Deleted conda-build-config.yaml since we build a noarch: python package
  • Deleted environment.yaml since it was comically out of date

In the dependencies:

pip install dask and conda install dask are not the same thing!

Conda's dask is all of Dask and all of its dependencies, even Pandas! What we want is actually dask-core, which is just all of Dask and equivalent to pip install dask.

Meanwhile, pip install dask installs all of Dask, and we only need the array part, so we can just require dask[array] to lighten it up.


Stole @cderwin's makefile from PyVeda to make OSX installs a little easier.

make osx sets the OpenSSL library options before pip installing


Fixed up the tests so they all pass and got rid of the AssertEqual warnings.

@drwelby drwelby requested review from Brett55 and rjpolackwich June 5, 2019 21:07
@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

Merging #767 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #767      +/-   ##
=========================================
- Coverage   81.44%   81.4%   -0.05%     
=========================================
  Files          91      91              
  Lines        6404    6404              
=========================================
- Hits         5216    5213       -3     
- Misses       1188    1191       +3
Impacted Files Coverage Δ
tests/unit/test_workflow.py 100% <100%> (ø) ⬆️
tests/unit/test_meta.py 100% <100%> (ø) ⬆️
tests/unit/test_simpleworkflow.py 98.9% <100%> (ø) ⬆️
tests/unit/test_image_fetch.py 100% <100%> (ø) ⬆️
tests/unit/test_interface.py 95.23% <100%> (-4.77%) ⬇️
gbdxtools/auth.py 87.75% <0%> (-4.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d846fec...68d7ae1. Read the comment docs.

@drwelby drwelby closed this Oct 24, 2019
@drwelby drwelby deleted the conda-pkg branch October 24, 2019 21:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants