Skip to content
This repository has been archived by the owner on Jan 4, 2022. It is now read-only.

S3 Delete Updates #800

Merged
merged 25 commits into from
Jan 8, 2020
Merged

S3 Delete Updates #800

merged 25 commits into from
Jan 8, 2020

Conversation

michaelconnor00
Copy link
Contributor

@michaelconnor00 michaelconnor00 changed the base branch from master to dev November 27, 2019 19:08
@codecov-io
Copy link

codecov-io commented Nov 27, 2019

Codecov Report

Merging #800 into dev will increase coverage by 0.4%.
The diff coverage is 98.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #800     +/-   ##
=========================================
+ Coverage   80.47%   80.88%   +0.4%     
=========================================
  Files          86       87      +1     
  Lines        6029     6088     +59     
=========================================
+ Hits         4852     4924     +72     
+ Misses       1177     1164     -13
Impacted Files Coverage Δ
tests/unit/test_s3.py 100% <100%> (ø) ⬆️
tests/unit/moto_test_data.py 100% <100%> (ø)
gbdxtools/s3.py 57.77% <96.29%> (+24.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fe758...09f8574. Read the comment docs.

@michaelconnor00
Copy link
Contributor Author

Fixed Travis and Appveyor builds. Also changed the merge target to dev. Ready to merge.

@drwelby drwelby merged commit 133b7fb into dev Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants