Skip to content

Commit

Permalink
Semver: specify VersionNumber's follow v2-rc2 specifically (JuliaLang…
Browse files Browse the repository at this point in the history
…#53538)

Since v2 has changed from v2-rc2 by saying build numbers MUST not be
taken into account in precedence.

I don't think changing VersionNumber's ordering in a minor release of
Julia is acceptable, but since the semver landing page is now v2 rather
than v2-rc2, we should update the link.

closes JuliaLang#53502
  • Loading branch information
ericphanson authored Mar 5, 2024
1 parent b50344f commit 3df016d
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions base/version.jl
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ const VInt = UInt32
VersionNumber
Version number type which follows the specifications of
[semantic versioning (semver)](https://semver.org/), composed of major, minor
[semantic versioning (semver)](https://semver.org/spec/v2.0.0-rc.2.html), composed of major, minor
and patch numeric values, followed by pre-release and build
alphanumeric annotations.
`VersionNumber` objects can be compared with all of the standard comparison
operators (`==`, `<`, `<=`, etc.), with the result following semver rules.
operators (`==`, `<`, `<=`, etc.), with the result following semver v2.0.0-rc.2 rules.
`VersionNumber` has the following public fields:
- `v.major::Integer`
Expand Down
2 changes: 1 addition & 1 deletion doc/src/manual/strings.md
Original file line number Diff line number Diff line change
Expand Up @@ -1142,7 +1142,7 @@ some confusion regarding the matter.

Version numbers can easily be expressed with non-standard string literals of the form [`v"..."`](@ref @v_str).
Version number literals create [`VersionNumber`](@ref) objects which follow the
specifications of [semantic versioning](https://semver.org/),
specifications of [semantic versioning 2.0.0-rc2](https://semver.org/spec/v2.0.0-rc.2.html),
and therefore are composed of major, minor and patch numeric values, followed by pre-release and
build alphanumeric annotations. For example, `v"0.2.1-rc1+win64"` is broken into major version
`0`, minor version `2`, patch version `1`, pre-release `rc1` and build `win64`. When entering
Expand Down

0 comments on commit 3df016d

Please sign in to comment.