Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base path on web and fullstack #3247

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

ealmloff
Copy link
Member

@ealmloff ealmloff commented Nov 21, 2024

This PR fixes the base path in the config and fixes the title of desktop apps in release mode. Reading a CLI config how has this matrix of sources:

Platform Debug mode (assumed to be running under the CLI) Release mode
Web Read from a <meta> tag Read from env!
Non-web Read from env at runtime Read from env!

Fixes #2928
Fixes #2929
Fixes #3159
Stacked on #3195

@ealmloff ealmloff added bug Something isn't working cli Related to the dioxus-cli program router Related to the router implementation labels Nov 21, 2024
@ealmloff ealmloff marked this pull request as ready for review November 23, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Related to the dioxus-cli program router Related to the router implementation
Projects
None yet
1 participant