Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(imgur.txt): refresh the list by 211126 #3

Merged
merged 2 commits into from
Dec 5, 2021
Merged

feat(imgur.txt): refresh the list by 211126 #3

merged 2 commits into from
Dec 5, 2021

Conversation

tai271828
Copy link
Contributor

@tai271828 tai271828 commented Nov 26, 2021 •
edited
Loading

Issue: #1

The execution result shows

Read lastResult file........                                                                                                                                                                                                                 
Read imgur.txt......
There are valid 0 files, and need to update 3120 
Saved - output/SP8RBV2.jpg
Saved - output/B1TdSL0.jpg
Saved - output/YMX0Mwg.jpg
Saved - output/2FDkXVM.jpg
Saved - output/c2DXT5o.png

<skipped>

Saved - output/A3Xrigc.jpg
Saved - output/RNrBYDF.jpg
Saved - output/3F4vWZd.jpg
Saved - output/cdJsxVf.jpg
Saved - output/YYBVySY.jpg
Saved - output/TQDzEhZ.jpg
Saved - output/6GTXXRx.jpg
Saved - output/cLq8YdD.jpg
Saved - output/n0nTLNy.jpg
✨ Success



┌─[^_^]─[~/work-my-projects/imgur-keeper]
  tai271828@syakaro: 15 file 660Kb
└──╼ ls output/ | wc -l
3119

The 3120 vs. 3119 seems to be caused by the duplicate entry Grqb5xy.jpg

tai271828
tai271828 commented Nov 26, 2021
View reviewed changes
imgur.txt
@@ -492,8 +502,6 @@ https://i.imgur.com/U5cG24w.jpg
https://i.imgur.com/AWSUMUy.jpg
https://i.imgur.com/dAhatL3.jpg
https://i.imgur.com/IfhwM4G.jpg
https://i.imgur.com/sdrisC2.jpg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the two missing items and the removal is expected.

@tai271828
Copy link
Contributor Author

@yoyo930021 It's my first time to scan the imgur urls. Would you mind reviewing what I have done (the output message and the flow) if you have a moment?
@deeper747 I was aware that some images were removed. I checked some of them randomly but not all of them. Would you mind reviewing the missing images to see if they fit your expectation?

@tai271828
feat(imgur.txt): refresh the cache of lastResult.json
9683a49 
Along with the commit 57fa7d4 updating the
image list, refresh the cache list.

Issue: Disfactory#1
@tai271828 tai271828 force-pushed the pr-update-url-by-211124 branch from ecc9a7c to 9683a49 Compare November 26, 2021 09:36
@tai271828 tai271828 mentioned this pull request Nov 26, 2021
Open
3 tasks
deeper747
deeper747 reviewed Dec 1, 2021
View reviewed changes
imgur.txt
@@ -1932,7 +3115,6 @@ https://i.imgur.com/Y5JbxBv.png
https://i.imgur.com/KTNCZLe.jpg
https://i.imgur.com/0OrBtEB.png
https://i.imgur.com/bNBXBj0.png
https://i.imgur.com/8RQ3bXc.jpg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was deleted by me these month since it was a testing file.

deeper747
deeper747 reviewed Dec 1, 2021
View reviewed changes
imgur.txt
@@ -790,8 +1975,6 @@ https://i.imgur.com/TrAsbQA.jpg
https://i.imgur.com/EUym73A.jpg
https://i.imgur.com/jHfap6m.jpg
https://i.imgur.com/ctfs8Qj.jpg
https://i.imgur.com/zrlVQlG.jpg
https://i.imgur.com/r1CKXK1.jpg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted /cause repetitive upload

@deeper747
Copy link
Member

@deeper747 I was aware that some images were removed. I checked some of them randomly but not all of them. Would you mind reviewing the missing images to see if they fit your expectation?

Randomly checked the highlighted items. All are deleted in purpose.
No problem so far in my opinion!

@tai271828 tai271828 merged commit b343f2f into Disfactory:master Dec 5, 2021
@tai271828 tai271828 deleted the pr-update-url-by-211124 branch December 5, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deeper747 deeper747 deeper747 approved these changes

@yoyo930021 yoyo930021 Awaiting requested review from yoyo930021

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tai271828 @deeper747