Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sku)!: change SKU.subscriptions to be a sync method #1274

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Jan 21, 2025

Summary

SKU.subscriptions mistakenly returned a coroutine, unlike other iterator methods (which are sync methods returning an async iterator). This removes the async keyword.

https://docs.astral.sh/ruff/rules/unused-async/ might have caught this, but the rule is currently still in preview.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added breaking change Includes breaking changes to code/packaging t: bugfix labels Jan 21, 2025
@shiftinv shiftinv added this to the disnake v2.11 milestone Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Includes breaking changes to code/packaging t: bugfix
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant