fix(sku)!: change SKU.subscriptions
to be a sync method
#1274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SKU.subscriptions
mistakenly returned a coroutine, unlike other iterator methods (which are sync methods returning an async iterator). This removes theasync
keyword.https://docs.astral.sh/ruff/rules/unused-async/ might have caught this, but the rule is currently still in preview.
Checklist
pdm lint
pdm pyright