Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): avoid installing dependencies outside of venv for pyright #978

Merged
merged 2 commits into from
Mar 10, 2023
Merged

fix(ci): avoid installing dependencies outside of venv for pyright #978

merged 2 commits into from
Mar 10, 2023

Conversation

shiftinv
Copy link
Member

@shiftinv shiftinv commented Mar 6, 2023

Summary

This avoids the pdm export + pip install -r workaround by adding the venv's bin path to $PATH.

#836 (comment)

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added s: needs review Issue/PR is awaiting reviews t: meta Changes to the project itself (CI, configs, etc.) skip news labels Mar 6, 2023
@onerandomusername onerandomusername enabled auto-merge (squash) March 10, 2023 23:10
@onerandomusername onerandomusername merged commit b13f9a9 into master Mar 10, 2023
@onerandomusername onerandomusername deleted the fix/ci-pyright-env branch March 10, 2023 23:14
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Apr 6, 2023
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onerandomusername onerandomusername onerandomusername approved these changes

Assignees
No one assigned
Labels
skip news t: meta Changes to the project itself (CI, configs, etc.)
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@shiftinv @onerandomusername