Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ruff and fix issues #923

Merged
merged 6 commits into from
Dec 31, 2023
Merged

Conversation

marksweb
Copy link
Collaborator

This switches flake8 and isort for ruff along with a thorough set of rules and appropirate excludes for the existing codebase.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #923 (44a4b34) into main (6090c9f) will increase coverage by 0.65%.
Report is 4 commits behind head on main.
The diff coverage is 82.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #923      +/-   ##
==========================================
+ Coverage   80.21%   80.87%   +0.65%     
==========================================
  Files          95       95              
  Lines        2856     2855       -1     
  Branches      274      269       -5     
==========================================
+ Hits         2291     2309      +18     
+ Misses        507      494      -13     
+ Partials       58       52       -6     
Files Coverage Δ
applications/decorators.py 100.00% <100.00%> (ø)
applications/services.py 66.66% <100.00%> (ø)
coach/models.py 78.37% <100.00%> (ø)
core/context_processors.py 100.00% <ø> (ø)
core/default_eventpage_content.py 83.33% <100.00%> (ø)
core/deploy_event.py 100.00% <100.00%> (+5.26%) ⬆️
core/management_utils.py 97.29% <ø> (ø)
core/models/event.py 95.40% <100.00%> (+1.14%) ⬆️
core/quotes.py 0.00% <ø> (ø)
core/views.py 97.53% <100.00%> (+2.35%) ⬆️
... and 17 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0632a98...44a4b34. Read the comment docs.

Copy link
Contributor

@amakarudze amakarudze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there are many coverage issues here @marksweb. Are you handling them or can I help with them so I can unblock my own PRs blocked by flake 8 issues?

@marksweb
Copy link
Collaborator Author

So there are many coverage issues here @marksweb. Are you handling them or can I help with them so I can unblock my own PRs blocked by flake 8 issues?

I'll take a look over it

Copy link
Contributor

@amakarudze amakarudze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @marksweb.

@amakarudze amakarudze merged commit 2e328a2 into DjangoGirls:main Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants