-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ruff and fix issues #923
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
+ Coverage 80.21% 80.87% +0.65%
==========================================
Files 95 95
Lines 2856 2855 -1
Branches 274 269 -5
==========================================
+ Hits 2291 2309 +18
+ Misses 507 494 -13
+ Partials 58 52 -6
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there are many coverage issues here @marksweb. Are you handling them or can I help with them so I can unblock my own PRs blocked by flake 8 issues?
I'll take a look over it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @marksweb.
This switches flake8 and isort for ruff along with a thorough set of rules and appropirate excludes for the existing codebase.