Deprecate the STRALGO command and implement the LCS in its place

Dltmd202 · Nov 12, 2024 · 7f6bf0f · 7f6bf0f
1 parent 66f2098
commit 7f6bf0f
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 32 deletions.
diff --git a/src/main/java/io/lettuce/core/cluster/api/async/NodeSelectionStringAsyncCommands.java b/src/main/java/io/lettuce/core/cluster/api/async/NodeSelectionStringAsyncCommands.java
@@ -420,22 +420,22 @@ public interface NodeSelectionStringAsyncCommands<K, V> {
      */
     AsyncExecutions<StringMatchResult> stralgoLcs(StrAlgoArgs strAlgoArgs);
 
-//    /**
-//     * The LCS command implements the longest common subsequence algorithm.
-//     *
-//     * <ul>
-//     * <li>Without modifiers the string representing the longest common substring is returned.</li>
-//     * <li>When {@link LcsArgs#justLen() LEN} is given the command returns the length of the longest common substring.</li>
-//     * <li>When {@link LcsArgs#withIdx() IDX} is given the command returns an array with the LCS length and all the ranges in
-//     * both the strings, start and end offset for each string, where there are matches. When {@link LcsArgs#withMatchLen()
-//     * WITHMATCHLEN} is given each array representing a match will also have the length of the match.</li>
-//     * </ul>
-//     *
-//     * @param lcsArgs command arguments.
-//     * @return StringMatchResult.
-//     * @since 6.6
-//     */
-//    AsyncExecutions<StringMatchResult> lcs(LcsArgs lcsArgs);
+    /**
+     * The LCS command implements the longest common subsequence algorithm.
+     *
+     * <ul>
+     * <li>Without modifiers the string representing the longest common substring is returned.</li>
+     * <li>When {@link LcsArgs#justLen() LEN} is given the command returns the length of the longest common substring.</li>
+     * <li>When {@link LcsArgs#withIdx() IDX} is given the command returns an array with the LCS length and all the ranges in
+     * both the strings, start and end offset for each string, where there are matches. When {@link LcsArgs#withMatchLen()
+     * WITHMATCHLEN} is given each array representing a match will also have the length of the match.</li>
+     * </ul>
+     *
+     * @param lcsArgs command arguments.
+     * @return StringMatchResult.
+     * @since 6.6
+     */
+    AsyncExecutions<StringMatchResult> lcs(LcsArgs lcsArgs);
 
     /**
      * Get the length of the value stored in a key.

diff --git a/src/main/java/io/lettuce/core/cluster/api/sync/NodeSelectionStringCommands.java b/src/main/java/io/lettuce/core/cluster/api/sync/NodeSelectionStringCommands.java
@@ -420,22 +420,22 @@ public interface NodeSelectionStringCommands<K, V> {
      */
     Executions<StringMatchResult> stralgoLcs(StrAlgoArgs strAlgoArgs);
 
-//    /**
-//     * The LCS command implements the longest common subsequence algorithm.
-//     *
-//     * <ul>
-//     * <li>Without modifiers the string representing the longest common substring is returned.</li>
-//     * <li>When {@link LcsArgs#justLen() LEN} is given the command returns the length of the longest common substring.</li>
-//     * <li>When {@link LcsArgs#withIdx() IDX} is given the command returns an array with the LCS length and all the ranges in
-//     * both the strings, start and end offset for each string, where there are matches. When {@link LcsArgs#withMatchLen()
-//     * WITHMATCHLEN} is given each array representing a match will also have the length of the match.</li>
-//     * </ul>
-//     *
-//     * @param lcsArgs command arguments.
-//     * @return StringMatchResult.
-//     * @since 6.6
-//     */
-//    Executions<StringMatchResult> lcs(LcsArgs lcsArgs);
+    /**
+     * The LCS command implements the longest common subsequence algorithm.
+     *
+     * <ul>
+     * <li>Without modifiers the string representing the longest common substring is returned.</li>
+     * <li>When {@link LcsArgs#justLen() LEN} is given the command returns the length of the longest common substring.</li>
+     * <li>When {@link LcsArgs#withIdx() IDX} is given the command returns an array with the LCS length and all the ranges in
+     * both the strings, start and end offset for each string, where there are matches. When {@link LcsArgs#withMatchLen()
+     * WITHMATCHLEN} is given each array representing a match will also have the length of the match.</li>
+     * </ul>
+     *
+     * @param lcsArgs command arguments.
+     * @return StringMatchResult.
+     * @since 6.6
+     */
+    Executions<StringMatchResult> lcs(LcsArgs lcsArgs);
 
     /**
      * Get the length of the value stored in a key.