Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image download redirect -> follow 30* from http to https #274

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

reapier
Copy link

@reapier reapier commented Jan 22, 2019

Fixes 1pondo scraper not working -- resolve #206
Scraping genres on 1pondo videos -- resolve #47

@reapier
Copy link
Author

reapier commented Jan 22, 2019

Please add me as a Collaborator

@Wizell
Copy link
Collaborator

Wizell commented Jun 12, 2019

Thank you for your PR.

I read the commits but I don't understand what do you want to do in the commit f4e7abf . Can you explain what is the idea ?

For the collaborator addition, i don't have access to this repository settings so i cannot add someone as a collaborator, only @DoctorD1501 is able to do such a thing.

Copy link
Collaborator

@Wizell Wizell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this patch but i see the following changes as required before merging:

  • Hard coding the user agent is not a good idea. Better keep the same user agent as the previous request or use the utility files to get a random user agent
  • the referer is not properly handled as for the nth redirect, the referer should be the nth-1 url not the given intial referer
  • 307 and 308 HTTP RC code check might also be required
  • i would rather avoid the use a while(true) even if the current code i don't see obvious flow it makes reading and cross checking more complex and is easier to make mistakes like moving the "break;" which would create an infinite loop

Copy link
Collaborator

@Wizell Wizell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tests accordingly. The file is OnePondoParsingProfileTest.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1pondo scraper not working Scraping genres on 1pondo videos
2 participants