workflows: fail properly for author wfs

* ref: cern-sis/issues-inspire/issues/643
DonHaul · Dec 19, 2024 · 79ef28b · 79ef28b
1 parent a6f8655
commit 79ef28b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/workflows/dags/author/author_create/author_create_approved.py b/workflows/dags/author/author_create/author_create_approved.py
@@ -29,12 +29,13 @@
         "workflow_id": Param(type="string", default=""),
         "data": Param(type="object", default={}),
         "create_ticket": Param(type="boolean", default=False),
+        "collection": Param(type="string", default=AUTHORS),
     },
     start_date=datetime.datetime(2024, 5, 5),
     schedule=None,
     catchup=False,
     on_failure_callback=set_workflow_status_to_error,  # TODO: what if callback fails? Data in backoffice not up to date!
-    tags=["authors"],
+    tags=[AUTHORS],
 )
 def author_create_approved_dag():
     """Defines the DAG for the author creation workflow after curator's approval.

diff --git a/workflows/dags/author/author_create/author_create_rejected.py b/workflows/dags/author/author_create/author_create_rejected.py
@@ -21,7 +21,7 @@
     catchup=False,
     # TODO: what if callback fails? Data in backoffice not up to date!
     on_failure_callback=set_workflow_status_to_error,
-    tags=["authors"],
+    tags=[AUTHORS],
 )
 def author_create_rejected_dag() -> None:
     """

diff --git a/workflows/dags/author/author_update/author_update.py b/workflows/dags/author/author_update/author_update.py
@@ -25,10 +25,11 @@
     params={
         "workflow_id": Param(type="string", default=""),
         "data": Param(type="object", default={}),
+        "collection": Param(type="string", default=AUTHORS),
     },
     catchup=False,
     on_failure_callback=set_workflow_status_to_error,  # TODO: what if callback fails? Data in backoffice not up to date!
-    tags=["authors"],
+    tags=[AUTHORS],
 )
 def author_update_dag():
     """