Skip to content

Commit

Permalink
more cleaning up
Browse files Browse the repository at this point in the history
  • Loading branch information
macher committed Oct 16, 2024
1 parent d6103eb commit 6aae719
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 13 deletions.
5 changes: 2 additions & 3 deletions modular_doppler/dopplerboop/dopplerboops.dm
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Currently the sound file must be passed as a sound datum. This was initially with the intention of using BYOND's in-built pitch on sound datums, but that sucks and has a bunch of weird issues. It does have the added benefit
* of giving a check to make sure we're actually passing a real sound file through to playsound_local, though.
*
* File format is as follows: [voice name]/[letter]_[variation].wav.
* File format is as follows: [voice name]/[letter][variation].wav.
* Each vowel has twenty variations, while each consonant has six.
* An Audacity macro to make the sounds less irritating on the ear was made and used to process each voice. It can be found in the initial PR related to this system.
*/
Expand Down Expand Up @@ -70,7 +70,6 @@

for(var/i in 1 to min(length(all_boops), MAX_DOPPLERBOOP_CHARACTERS))
var/volume = initial_volume
var/falloff_exponent = initial_falloff
var/current_delay = initial_delay
if(!all_boops[i] || all_boops[i] == " ")
continue
Expand All @@ -91,7 +90,7 @@
variation = rand(1, 5)
final_boop = sound("modular_doppler/dopplerboop/voices/[chosen_boop]/[boop_letter][variation].wav")

addtimer(CALLBACK(src, PROC_REF(play_dopplerboop), hearers, dopplerbooper, final_boop, volume, initial_dopplerboop_time, falloff_exponent, frequency), dopplerboop_delay_cumulative + current_delay)
addtimer(CALLBACK(src, PROC_REF(play_dopplerboop), hearers, dopplerbooper, final_boop, volume, initial_dopplerboop_time, initial_falloff, frequency), dopplerboop_delay_cumulative + current_delay)
dopplerboop_delay_cumulative += current_delay

/datum/component/dopplerboop/proc/play_dopplerboop(list/hearers, mob/dopplerbooper, final_boop, volume, initial_dopplerboop_time, falloff_exponent, freq)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/// Middleware gamejacked fromfrom TTS preview.
/// Middleware gamejacked from TTS preview.
/datum/preference_middleware/dopplerboop
/// Cooldown on requesting a TTS preview.
/// Cooldown on requesting a dopplerboop preview.
COOLDOWN_DECLARE(dopplerboop_cooldown)

action_delegations = list(
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
import { Button, Stack } from '../../../../../../components';
import {
FeatureChoiced,
FeatureChoicedServerData,
FeatureValueProps,
} from '../../base';
import { FeatureChoiced, FeatureValueProps } from '../../base';
import { FeatureDropdownInput } from '../../dropdowns';

const FeatureBoopDropdownInput = (
props: FeatureValueProps<string, string, FeatureChoicedServerData>,
) => {
const FeatureBoopDropdownInput = (props: FeatureValueProps<string>) => {
return (
<Stack>
<Stack.Item grow>
Expand Down

0 comments on commit 6aae719

Please sign in to comment.