Apply suggestions from code review

Co-authored-by: Tom <[email protected]> Signed-off-by: CliffracerX <[email protected]>
DopplerShift13 · Oct 19, 2024 · ee31e90 · ee31e90
1 parent c433dfb
commit ee31e90
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/modular_doppler/_HELPERS/preferences.dm b/modular_doppler/_HELPERS/preferences.dm
@@ -12,5 +12,5 @@ GLOBAL_LIST_INIT(dopplerboop_voice_types, sort_list(list(
 	"jock",
 	"lazy",
 	"smug",
-	"mute"
+	"mute",
 )))
diff --git a/modular_doppler/dopplerboop/dopplerboops.dm b/modular_doppler/dopplerboop/dopplerboops.dm
@@ -99,6 +99,6 @@
 	if(!volume || (last_dopplerboop != initial_dopplerboop_time) || !final_boop)
 		return
 	for(var/mob/hearer as anything in hearers)
-		var/user_volume = hearer.client.prefs.read_preference(/datum/preference/numeric/voice_volume)
+		var/user_volume = hearer.client?.prefs.read_preference(/datum/preference/numeric/voice_volume)
 		volume = volume*(user_volume / 10)
 		hearer.playsound_local(turf_source = get_turf(dopplerbooper), sound_to_use = final_boop, vol = volume, vary = TRUE, frequency = freq, falloff_distance = falloff_exponent, max_distance = 16)
diff --git a/modular_doppler/modular_customization/preferences/middleware/dopplerboops.dm b/modular_doppler/modular_customization/preferences/middleware/dopplerboops.dm
@@ -13,7 +13,7 @@
 	var/boop_letter = null
 	var/dopplerboop_delay_cumulative = 0
 	var/sound/final_boop = null
-	var/user_volume = user.client.prefs.read_preference(/datum/preference/numeric/voice_volume)
+	var/user_volume = user.client?.prefs.read_preference(/datum/preference/numeric/voice_volume)
 
 	for(var/i in 1 to min(length(all_boops), MAX_DOPPLERBOOP_CHARACTERS))
 		var/volume = DOPPLERBOOP_DEFAULT_VOLUME
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,5 +12,5 @@ GLOBAL_LIST_INIT(dopplerboop_voice_types, sort_list(list( @@
     	"jock",
     	"lazy",
     	"smug",
-    	"mute"
+    	"mute",
     )))