TG live PR #112
Merged
TG live PR #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request pruned higher frequencies of the sound to make it less jarring on the ears: ### Before: https://github.com/user-attachments/assets/21387908-bf2f-4f34-8c39-f724b3f2be17 ### After: https://github.com/user-attachments/assets/9ced7b0e-e03c-4ff7-801a-34254e0273bd <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game higher frequency sounds hurt the ears, this should make it better. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: grungussuss sound: pruned higher frequencies from the resonant shriek ability sound, making it lighter on the ears /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
## About The Pull Request closes tgstation#68437 ### comparison: https://github.com/user-attachments/assets/196b6b8c-988d-4736-8e00-e7e8d8c89ca3 https://github.com/user-attachments/assets/e78a1c6a-43ba-4cf1-abb5-9dda2a9d05c4 ## Why It's Good For The Game This is better. ## Changelog :cl: grungussuss sound: lavaland magma ambience has been changed /:cl:
…4.6.4 (tgstation#86803) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 3.7.1 to 4.6.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/jamesives/github-pages-deploy-action/releases">JamesIves/github-pages-deploy-action's releases</a>.</em></p> <blockquote> <h2>v4.6.4</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h2>What's Changed</h2> <h3>Bug Fixes 🐝</h3> <ul> <li>fix: resolved an issue where the default config was not being applied to the non-action version of the project.</li> </ul> <h3>Build 🔧</h3> <ul> <li>build(deps): bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1639">JamesIves/github-pages-deploy-action#1639</a></li> <li>build(deps): bump the misc group across 1 directory with 6 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1642">JamesIves/github-pages-deploy-action#1642</a></li> <li>build(deps): bump the misc group across 1 directory with 8 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1648">JamesIves/github-pages-deploy-action#1648</a></li> <li>build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 in the misc group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1649">JamesIves/github-pages-deploy-action#1649</a></li> <li>build(deps): bump micromatch from 4.0.4 to 4.0.8 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1679">JamesIves/github-pages-deploy-action#1679</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.4">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.4</a></p> <h2>v4.6.3</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Build 🔧</h3> <ul> <li>Consolidated a number of build scripts to make publishing easier.</li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.3">https://github.com/JamesIves/github-pages-deploy-action/compare/v4...v4.6.3</a></p> <h2>v4.6.2</h2> <!-- raw HTML omitted --> <h2>What's Changed</h2> <h3>Dependencies 🤖</h3> <ul> <li>build(deps-dev): bump the misc group across 1 directory with 2 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1602">JamesIves/github-pages-deploy-action#1602</a></li> <li>build(deps): bump codecov/codecov-action from 4.4.0 to 4.5.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1614">JamesIves/github-pages-deploy-action#1614</a></li> <li>build(deps): bump braces from 3.0.2 to 3.0.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1615">JamesIves/github-pages-deploy-action#1615</a></li> <li>build(deps-dev): bump the misc group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1613">JamesIves/github-pages-deploy-action#1613</a></li> <li>build(deps-dev): bump the misc group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1635">JamesIves/github-pages-deploy-action#1635</a></li> <li>build(deps): bump typescript-eslint from 7.9.0 to 7.15.0 in the typescript group across 1 directory by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1634">JamesIves/github-pages-deploy-action#1634</a></li> <li>build(deps-dev): bump the eslint group across 1 directory with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/JamesIves/github-pages-deploy-action/pull/1637">JamesIves/github-pages-deploy-action#1637</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/JamesIves/github-pages-deploy-action/compare/v4.6.1...v4.6.2">https://github.com/JamesIves/github-pages-deploy-action/compare/v4.6.1...v4.6.2</a></p> <h2>v4.6.1</h2> <h2>What's Changed</h2> <h3>Fixes</h3> <ul> <li>Resolved an issue where workflows were suddenly failing due to a worktree in use error. The action will now attempt to create a temp branch name if the existing branch name is already checked out by a prior to step to ensure it can occur. This issue was only occurring in a handful of workflows, and likely stemmed from a git version change on the official GitHub runners. The actual root cause is still somewhat unknown.</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/920cbb300dcd3f0568dbc42700c61e2fd9e6139c"><code>920cbb3</code></a> Deploy Production Code for Commit 2323e0195f287f854c36d6aa47e2cebe03989e7c 🚀</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/2323e0195f287f854c36d6aa47e2cebe03989e7c"><code>2323e01</code></a> Merge branch 'dev' into releases/v4</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/739329c69269ec18c80bd9557a0e2e85ad9d3de0"><code>739329c</code></a> Update lib.ts</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/ab1e83de25e9910eda868909638a097567373be8"><code>ab1e83d</code></a> Update lib.ts</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/78379c7dcccfb7699db0f9232a2d871d55259d5a"><code>78379c7</code></a> Merge branch 'dev' into releases/v4</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/52f022e6db4a165d00a9980fbfbae83ebce9296b"><code>52f022e</code></a> chore: format</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/fa0c379aacd98748b423933314fa3b83e1596f1f"><code>fa0c379</code></a> fix: 🐛 Properly set default config for usage as node module</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/361d3f08657ec43688f8a7cc16a3311786364a63"><code>361d3f0</code></a> build(deps): bump micromatch from 4.0.4 to 4.0.8 (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1679">#1679</a>)</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/90f61c82db95eb723d571cd8524d1877f29d507e"><code>90f61c8</code></a> build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 in the misc group (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1649">#1649</a>)</li> <li><a href="https://github.com/JamesIves/github-pages-deploy-action/commit/6f031e0208550d68cce5cf11387de8ab2e0d8ed9"><code>6f031e0</code></a> build(deps): bump the misc group across 1 directory with 8 updates (<a href="https://redirect.github.com/jamesives/github-pages-deploy-action/issues/1648">#1648</a>)</li> <li>Additional commits viewable in <a href="https://github.com/jamesives/github-pages-deploy-action/compare/3.7.1...v4.6.4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jordan Dominion <[email protected]>
Bumps [actions/stale](https://github.com/actions/stale) from 4 to 9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p> <blockquote> <h2>v9.0.0</h2> <h2>Breaking Changes</h2> <ol> <li>Action is now stateful: If the action ends because of <a href="https://github.com/actions/stale#operations-per-run">operations-per-run</a> then the next run will start from the first unprocessed issue skipping the issues processed during the previous run(s). The state is reset when all the issues are processed. This should be considered for scheduling workflow runs.</li> <li>Version 9 of this action updated the runtime to Node.js 20. All scripts are now run with Node.js 20 instead of Node.js 16 and are affected by any breaking changes between Node.js 16 and 20.</li> </ol> <h2>What Else Changed</h2> <ol> <li>Performance optimization that removes unnecessary API calls by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/1033/">#1033</a> fixes <a href="https://redirect.github.com/actions/stale/issues/792">#792</a></li> <li>Logs displaying current github API rate limit by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/1032">#1032</a> addresses <a href="https://redirect.github.com/actions/stale/issues/1029">#1029</a></li> </ol> <p>For more information, please read the <a href="https://github.com/actions/stale#readme">action documentation</a> and its <a href="https://github.com/actions/stale#statefulness">section about statefulness</a></p> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/jmeridth"><code>@jmeridth</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/984">actions/stale#984</a></li> <li><a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1020">actions/stale#1020</a></li> <li><a href="https://github.com/dusan-trickovic"><code>@dusan-trickovic</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1056">actions/stale#1056</a></li> <li><a href="https://github.com/aparnajyothi-y"><code>@aparnajyothi-y</code></a> made their first contribution in <a href="https://redirect.github.com/actions/stale/pull/1110">actions/stale#1110</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/stale/compare/v8...v9.0.0">https://github.com/actions/stale/compare/v8...v9.0.0</a></p> <h2>v8.0.0</h2> <p>:warning: This version contains breaking changes :warning:</p> <h2>What's Changed</h2> <ul> <li>New option labels-to-remove-when-stale enables users to specify list of comma delimited labels that will be removed when the issue or PR becomes stale by <a href="https://github.com/panticmilos"><code>@panticmilos</code></a> <a href="https://redirect.github.com/actions/stale/issues/770">actions/stale#770</a></li> <li>Skip deleting the branch in the upstream of a forked repo by <a href="https://github.com/dsame"><code>@dsame</code></a> <a href="https://redirect.github.com/actions/stale/pull/913">actions/stale#913</a></li> <li>abort the build on the error by <a href="https://github.com/dsame"><code>@dsame</code></a> in <a href="https://redirect.github.com/actions/stale/pull/935">actions/stale#935</a></li> </ul> <h2>Breaking Changes</h2> <ul> <li>In this release we prevent scenarios when the build is not interrupted on some exceptions, which led to successful builds when they are supposed to fail</li> </ul> <h2>Example</h2> <pre lang="yaml"><code>name: 'Remove labels when the issue or PR becomes stale' on: schedule: - cron: '30 1 * * *' <p>permissions: pull-requests: write</p> <p>jobs: stale: runs-on: ubuntu-latest steps: - uses: actions/stale@v8 with: labels-to-remove-when-stale: 'label1,label2' </code></pre></p> <h2>v7.0.0</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/blob/main/CHANGELOG.md">actions/stale's changelog</a>.</em></p> <blockquote> <h1>Changelog</h1> <h1>[7.0.0]</h1> <p>:warning: Breaking change :warning:</p> <ul> <li>Allow daysBeforeStale options to be float by <a href="https://github.com/irega"><code>@irega</code></a> in <a href="https://redirect.github.com/actions/stale/pull/841">actions/stale#841</a></li> <li>Use cache in check-dist.yml by <a href="https://github.com/jongwooo"><code>@jongwooo</code></a> in <a href="https://redirect.github.com/actions/stale/pull/876">actions/stale#876</a></li> <li>fix print outputs step in existing workflows by <a href="https://github.com/irega"><code>@irega</code></a> in <a href="https://redirect.github.com/actions/stale/pull/859">actions/stale#859</a></li> <li>Update issue and PR templates, add/delete workflow files by <a href="https://github.com/IvanZosimov"><code>@IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/stale/pull/880">actions/stale#880</a></li> <li>Update how stale handles exempt items by <a href="https://github.com/johnsudol"><code>@johnsudol</code></a> in <a href="https://redirect.github.com/actions/stale/pull/874">actions/stale#874</a></li> </ul> <h1>[6.0.1]</h1> <p>Update <code>@actions/core</code> to v1.10.0 (<a href="https://redirect.github.com/actions/stale/pull/839">#839</a>)</p> <h1>[6.0.0]</h1> <p>:warning: Breaking change :warning:</p> <p>Issues/PRs default <code>close-issue-reason</code> is now <code>not_planned</code>(<a href="https://redirect.github.com/actions/stale/issues/789">#789</a>)</p> <h1>[5.1.0]</h1> <p><a href="https://redirect.github.com/actions/stale/issues/696">Don't process stale issues right after they're marked stale</a> [Add close-issue-reason option]<a href="https://redirect.github.com/actions/stale/pull/764">#764</a><a href="https://redirect.github.com/actions/stale/pull/772">#772</a> Various dependabot/dependency updates</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/stale/commit/28ca1036281a5e5922ead5184a1bbf96e5fc984e"><code>28ca103</code></a> Upgrade Node to v20 (<a href="https://redirect.github.com/actions/stale/issues/1110">#1110</a>)</li> <li><a href="https://github.com/actions/stale/commit/b69b346013879cedbf50c69f572cd85439a41936"><code>b69b346</code></a> build(deps-dev): bump <code>@types/node</code> from 18.16.18 to 20.5.1 (<a href="https://redirect.github.com/actions/stale/issues/1079">#1079</a>)</li> <li><a href="https://github.com/actions/stale/commit/88a6f4f6cbe6984b66da80d3d448d5f0c4d1a42d"><code>88a6f4f</code></a> build(deps-dev): bump typescript from 5.1.3 to 5.2.2 (<a href="https://redirect.github.com/actions/stale/issues/1083">#1083</a>)</li> <li><a href="https://github.com/actions/stale/commit/796531a7b39835671cd9f436d7205b1556bbcff6"><code>796531a</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1080">#1080</a> from akv-platform/fix-delete-cache</li> <li><a href="https://github.com/actions/stale/commit/8986f6218b4935e254d5b844e8c36b4d953f2643"><code>8986f62</code></a> Don not try to delete cache if it does not exists</li> <li><a href="https://github.com/actions/stale/commit/cab99b362baa5afbbd8c7c78234e6b071b80687d"><code>cab99b3</code></a> fix typo proceeded/processed</li> <li><a href="https://github.com/actions/stale/commit/184e7afe930f6b5c7ce52c4b3f087692c6e912f3"><code>184e7af</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1064">#1064</a> from actions/dependabot/npm_and_yarn/typescript-esli...</li> <li><a href="https://github.com/actions/stale/commit/523885cf3c115dcdcbed573c7eaf0f5621f124e2"><code>523885c</code></a> chore: update eslint-plugin, parser and eslint-plugin-jest</li> <li><a href="https://github.com/actions/stale/commit/2487a1dc2b501176ca975d2d8b4d3293d72180a2"><code>2487a1d</code></a> build(deps-dev): bump <code>@typescript-eslint/eslint-plugin</code></li> <li><a href="https://github.com/actions/stale/commit/60c722ee97faafece819a7c41b03ec113f99717d"><code>60c722e</code></a> Merge pull request <a href="https://redirect.github.com/actions/stale/issues/1063">#1063</a> from actions/dependabot/npm_and_yarn/jest-29.6.2</li> <li>Additional commits viewable in <a href="https://github.com/actions/stale/compare/v4...v9">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 1 to 5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-python/releases">actions/setup-python's releases</a>.</em></p> <blockquote> <h2>v5.0.0</h2> <h2>What's Changed</h2> <p>In scope of this release, we update node version runtime from node16 to node20 (<a href="https://redirect.github.com/actions/setup-python/pull/772">actions/setup-python#772</a>). Besides, we update dependencies to the latest versions.</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0">https://github.com/actions/setup-python/compare/v4.8.0...v5.0.0</a></p> <h2>v4.8.0</h2> <h2>What's Changed</h2> <p>In scope of this release we added support for GraalPy (<a href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a>). You can use this snippet to set up GraalPy:</p> <pre lang="yaml"><code>steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py </code></pre> <p>Besides, the release contains such changes as:</p> <ul> <li>Trim python version when reading from file by <a href="https://github.com/FerranPares"><code>@FerranPares</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li> <li>Use non-deprecated versions in examples by <a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li> <li>Change deprecation comment to past tense by <a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/723">actions/setup-python#723</a></li> <li>Bump <code>@babel/traverse</code> from 7.9.0 to 7.23.2 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/743">actions/setup-python#743</a></li> <li>advanced-usage.md: Encourage the use actions/checkout@v4 by <a href="https://github.com/cclauss"><code>@cclauss</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/729">actions/setup-python#729</a></li> <li>Examples now use checkout@v4 by <a href="https://github.com/simonw"><code>@simonw</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/738">actions/setup-python#738</a></li> <li>Update actions/checkout to v4 by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/761">actions/setup-python#761</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/FerranPares"><code>@FerranPares</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/628">actions/setup-python#628</a></li> <li><a href="https://github.com/timfel"><code>@timfel</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/694">actions/setup-python#694</a></li> <li><a href="https://github.com/jeffwidman"><code>@jeffwidman</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-python/pull/724">actions/setup-python#724</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.8.0">https://github.com/actions/setup-python/compare/v4...v4.8.0</a></p> <h2>v4.7.1</h2> <h2>What's Changed</h2> <ul> <li>Bump word-wrap from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/702">actions/setup-python#702</a></li> <li>Add range validation for toml files by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-python/pull/726">actions/setup-python#726</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-python/compare/v4...v4.7.1">https://github.com/actions/setup-python/compare/v4...v4.7.1</a></p> <h2>v4.7.0</h2> <p>In scope of this release, the support for reading python version from pyproject.toml was added (<a href="https://redirect.github.com/actions/setup-python/pull/669">actions/setup-python#669</a>).</p> <pre lang="yaml"><code> - name: Setup Python uses: actions/setup-python@v4 </tr></table> </code></pre> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-python/commit/f677139bbe7f9c59b41e40162b753c062f5d49a3"><code>f677139</code></a> Bump pyinstaller from 3.6 to 5.13.1 in /<strong>tests</strong>/data (<a href="https://redirect.github.com/actions/setup-python/issues/923">#923</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/2bd53f9a4d1dd1cd21eaffcc01a7b91a8e73ea4c"><code>2bd53f9</code></a> Documentation update for caching poetry dependencies (<a href="https://redirect.github.com/actions/setup-python/issues/908">#908</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/80b49d3ed89312896dbdcbefc2ddb159c7f8ca43"><code>80b49d3</code></a> fix: add arch to cache key (<a href="https://redirect.github.com/actions/setup-python/issues/896">#896</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/036a5236741fd24c89eea80d1b76179e8e5f9214"><code>036a523</code></a> Fix: Add <code>.zip</code> extension to Windows package downloads for <code>Expand-Archive</code> C...</li> <li><a href="https://github.com/actions/setup-python/commit/04c1311429f7be71707d8ab66c7af8a14e54b938"><code>04c1311</code></a> Fix display of emojis in contributors doc (<a href="https://redirect.github.com/actions/setup-python/issues/899">#899</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/cb6845644151e35f879e10f2f0896c3c8bee372c"><code>cb68456</code></a> Updated <code>@iarna/toml</code> version to 3.0.0 (<a href="https://redirect.github.com/actions/setup-python/issues/912">#912</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/39cd14951b08e74b54015e9e001cdefcf80e669f"><code>39cd149</code></a> Documentation update for cache (<a href="https://redirect.github.com/actions/setup-python/issues/873">#873</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/a0d74c0c423f896bc4e7be91d5cb1e2d54438db3"><code>a0d74c0</code></a> fix(ci): update all failing workflows (<a href="https://redirect.github.com/actions/setup-python/issues/863">#863</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/4eb7dbcb9561cb76a85079ffa9d89b983166e00c"><code>4eb7dbc</code></a> Bump braces from 3.0.2 to 3.0.3 (<a href="https://redirect.github.com/actions/setup-python/issues/893">#893</a>)</li> <li><a href="https://github.com/actions/setup-python/commit/82c7e631bb3cdc910f68e0081d67478d79c6982d"><code>82c7e63</code></a> Documentation changes for avoiding rate limit issues on GHES (<a href="https://redirect.github.com/actions/setup-python/issues/835">#835</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/setup-python/compare/v1...v5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ation#86806) Bumps [robinraju/release-downloader](https://github.com/robinraju/release-downloader) from 1.9 to 1.11. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/robinraju/release-downloader/releases">robinraju/release-downloader's releases</a>.</em></p> <blockquote> <h2>Release Downloader v1.11</h2> <h2>What's Changed</h2> <ul> <li>Fix <code>No assets found in release</code> error by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/722">robinraju/release-downloader#722</a></li> <li>Update project config and dependencies by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/723">robinraju/release-downloader#723</a></li> <li>Bump <code>@types/tar</code> from 6.1.12 to 6.1.13 in the npm-development group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/724">robinraju/release-downloader#724</a></li> <li>Bump the npm-development group with 3 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/725">robinraju/release-downloader#725</a></li> <li>Bump the npm-development group across 1 directory with 4 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/730">robinraju/release-downloader#730</a></li> <li>Bump tar from 7.0.1 to 7.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/727">robinraju/release-downloader#727</a></li> <li>Bump the npm-development group across 1 directory with 7 updates by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/742">robinraju/release-downloader#742</a></li> <li>Bump braces from 3.0.2 to 3.0.3 in the npm_and_yarn group by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/737">robinraju/release-downloader#737</a></li> <li>Bump tar from 7.1.0 to 7.4.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/741">robinraju/release-downloader#741</a></li> <li>Bump typed-rest-client from 1.8.11 to 2.0.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/744">robinraju/release-downloader#744</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/robinraju/release-downloader/compare/v1.10...v1.11">https://github.com/robinraju/release-downloader/compare/v1.10...v1.11</a></p> <h2>Release Downloader v1.10</h2> <h2>What's Changed</h2> <ul> <li>Update README.md by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/680">robinraju/release-downloader#680</a></li> <li>Bump actions/checkout from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/687">robinraju/release-downloader#687</a></li> <li>Bump actions/setup-node from 3 to 4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/686">robinraju/release-downloader#686</a></li> <li>Bump nock from 13.3.8 to 13.5.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/685">robinraju/release-downloader#685</a></li> <li>Bump <code>@types/node</code> from 20.11.8 to 20.11.10 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/682">robinraju/release-downloader#682</a></li> <li>Bump typescript from 5.0.4 to 5.3.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/683">robinraju/release-downloader#683</a></li> <li>Bump <code>@vercel/ncc</code> from 0.36.1 to 0.38.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/684">robinraju/release-downloader#684</a></li> <li>Bump eslint-plugin-prettier from 5.0.1 to 5.1.3 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/681">robinraju/release-downloader#681</a></li> <li>fix: change zip library to fix garbled extract file under node 20 by <a href="https://github.com/jackie-linz"><code>@jackie-linz</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/707">robinraju/release-downloader#707</a></li> <li>Fix tests on windows, and package bundled js by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/710">robinraju/release-downloader#710</a></li> <li>Bump undici from 5.27.2 to 5.28.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/705">robinraju/release-downloader#705</a></li> <li>Bump tar from 6.2.0 to 6.2.1 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/711">robinraju/release-downloader#711</a></li> <li>Grouped dependancy updates by <a href="https://github.com/robinraju"><code>@robinraju</code></a> in <a href="https://redirect.github.com/robinraju/release-downloader/pull/713">robinraju/release-downloader#713</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/jackie-linz"><code>@jackie-linz</code></a> made their first contribution in <a href="https://redirect.github.com/robinraju/release-downloader/pull/707">robinraju/release-downloader#707</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/robinraju/release-downloader/compare/v1.9...v1.10">https://github.com/robinraju/release-downloader/compare/v1.9...v1.10</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/robinraju/release-downloader/commit/a96f54c1b5f5e09e47d9504526e96febd949d4c2"><code>a96f54c</code></a> Bump typed-rest-client from 1.8.11 to 2.0.1 (<a href="https://redirect.github.com/robinraju/release-downloader/issues/744">#744</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/821aec8754d281c38e1cea249e939ed5af9fc669"><code>821aec8</code></a> Bump tar from 7.1.0 to 7.4.0 (<a href="https://redirect.github.com/robinraju/release-downloader/issues/741">#741</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/8e9e67a554d01323e1d7462d33eef8a2668e949b"><code>8e9e67a</code></a> Bump braces from 3.0.2 to 3.0.3 in the npm_and_yarn group (<a href="https://redirect.github.com/robinraju/release-downloader/issues/737">#737</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/a3cbfc11eebbb78b3b756c8e1e79ea72f0f569d6"><code>a3cbfc1</code></a> Bump the npm-development group across 1 directory with 7 updates (<a href="https://redirect.github.com/robinraju/release-downloader/issues/742">#742</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/2c0dbf1decf5a80c2fccc8c11dd930dfd427613f"><code>2c0dbf1</code></a> Bump tar from 7.0.1 to 7.1.0 (<a href="https://redirect.github.com/robinraju/release-downloader/issues/727">#727</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/8ecfadfd54d1e0313cd0f81fb148f168ffb20b6d"><code>8ecfadf</code></a> Bump the npm-development group across 1 directory with 4 updates (<a href="https://redirect.github.com/robinraju/release-downloader/issues/730">#730</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/8d13112ee2bcab98efd42aaa11b373429735ea80"><code>8d13112</code></a> Bump the npm-development group with 3 updates (<a href="https://redirect.github.com/robinraju/release-downloader/issues/725">#725</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/8e6a4e0026189fd811225dc1347d00fafb4d9563"><code>8e6a4e0</code></a> Bump <code>@types/tar</code> from 6.1.12 to 6.1.13 in the npm-development group (<a href="https://redirect.github.com/robinraju/release-downloader/issues/724">#724</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/6c76fddc2c9fe3a60e46f40bf36544738c020f96"><code>6c76fdd</code></a> Update project config and dependencies (<a href="https://redirect.github.com/robinraju/release-downloader/issues/723">#723</a>)</li> <li><a href="https://github.com/robinraju/release-downloader/commit/cb096d8fa1fcb0e897f30b1c571f07e2c8e12479"><code>cb096d8</code></a> Fix <code>No assets found in release</code> error (<a href="https://redirect.github.com/robinraju/release-downloader/issues/722">#722</a>)</li> <li>Additional commits viewable in <a href="https://github.com/robinraju/release-downloader/compare/v1.9...v1.11">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
TGS now does some validation of the access token you give it, which doesn't work well in an actions environment. Just don't give it a token unless absolutely necessary. Private repos can eat shit cause this is AGPL code.
…6782) Removed the only instance of `only_forced_audio = TRUE` in /tg/, replaced with `cooldown = (5 SECONDS)`. The variable is still there in case someone needs it. ## About The Pull Request The variable was introduced in tgstation#42216 to prevent it from getting annoying. I discussed this change on the forums, previously assuming it was server config https://tgstation13.org/phpBB/viewtopic.php?f=9&t=37131 and people seemed receptive to the idea, spam being the only concern. ## Why It's Good For The Game There are better ways to prevent spam. Extending the cooldown is more favorable than being blocked completely (this is the treatment cyborg *deathgasp received, which is a longer, more jarring sound). Audible emotes help you grab the attention of others (for better or worse). I genuinely find them amusing at times & they remind me of the person on the other side. There is some limit to play-pretend. These emotes enabled some interactions with players I would not have had otherwise. As long as we stop the spam, it breathes some life into a game full of clicking, pointing at people and typing indicators. ## Changelog :cl: del: Intentional screaming has been unmuted. Now has a 5s cooldown instead. /:cl:
…ion#86822) ## About The Pull Request Closes tgstation#52590 ## Changelog :cl: fix: Emergency shuttle console no longer reopens its UI on its own /:cl:
…6812) ## About The Pull Request Diseases copy their instances, so they should be cleaned up afterwards Closes tgstation#86800 ## Changelog :cl: fix: Fixed infective components not cleaning up disease datums after themselves /:cl:
## About The Pull Request Rewrites a good chunk of express console code, removing one letter variables, duplicate code and straightening all the staircases with early returns. RIP cooldowns in ui_data() Mapped-in consoles now actually work, as currently they initialize before SSshuttles which results in them having a completely empty packs menu. This is fixed by making them report themselves to SSshuttles which will call package init on them once it itself initializes. Emagging the console will update the prices in the UI, and emagged consoles will try to send at least 1 package instead of requiring the budget to have enough funds to send all 5 pods. Because when you press a button with a price tag on it, you'd expect at least something to happen. Beacons now reset their offsets when anchored because thats been triggering my OCD. Upgrade disks aren't deleted and instead drop when the console is deconstructed. ## Why It's Good For The Game Code is crunchy, stuff is broken, prices aren't displayed correctly when the console is emagged and you'd expect at least something to arrive when you press a button with a price that you can afford. ## Changelog :cl: fix: Mapped in express supply consoles now work instead of displaying an empty UI. fix: Emagged express supply consoles now display updated prices. refactor: Rewrote a large chunk of express supply console code balance: Express supply consoles now drop their upgrade disk upon being deconstructed, and emagged consoles now will try to send at least one package to the station if cargo budget doesn't have enough funds for all 5. /:cl:
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 2 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p> <blockquote> <h2>v4.0.0</h2> <h2>What's Changed</h2> <p>In the scope of this release, the version of the Node.js runtime was updated to 20. The majority of dependencies were updated to the latest versions. From now on, the code for the setup-dotnet will run on Node.js 20 instead of Node.js 16.</p> <p><strong>Breaking changes</strong></p> <ul> <li>Update Node.js runtime to version 20 by <a href="https://github.com/harithavattikuti"><code>@harithavattikuti</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/issues/484">#484</a></li> <li>Sequential version install fix by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/433">actions/setup-dotnet#433</a> In setup-dotnet@v3, the dotnet executable was overwritten during each action run, sometimes leading to failures if the executable was still in use. This issue was resolved in setup-dotnet@v4 by introducing an additional install-script run that installs the LTS version of the dotnet executable and utilizes it for all subsequent dotnet installations. The actual download is performed only once per workflow by the initial install-script run. To use older versions, utilize global.json. For more details, refer to the <a href="https://github.com/actions/setup-dotnet?tab=readme-ov-file#usage">documentation</a>.</li> </ul> <p><strong>Non-breaking changes</strong></p> <ul> <li>Refactor installer by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/432">actions/setup-dotnet#432</a></li> <li>Allow json comments by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/431">actions/setup-dotnet#431</a></li> <li>Update fast-xml-parser and dotnet installer scripts by <a href="https://github.com/IvanZosimov"><code>@IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/437">actions/setup-dotnet#437</a></li> <li>Update dependencies by <a href="https://github.com/IvanZosimov"><code>@IvanZosimov</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/440">actions/setup-dotnet#440</a></li> <li>Bump word-wrap from 1.2.3 to 1.2.4 by <a href="https://github.com/dependabot"><code>@dependabot</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/444">actions/setup-dotnet#444</a></li> <li>Update installers by <a href="https://github.com/nikolai-laevskii"><code>@nikolai-laevskii</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/462">actions/setup-dotnet#462</a></li> <li>Update semver by <a href="https://github.com/dmitry-shibanov"><code>@dmitry-shibanov</code></a> in <a href="https://redirect.github.com/actions/setup-dotnet/pull/468">actions/setup-dotnet#468</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/HarithaVattikuti"><code>@HarithaVattikuti</code></a> made their first contribution in <a href="https://redirect.github.com/actions/setup-dotnet/pull/484">actions/setup-dotnet#484</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-dotnet/compare/v3...v4.0.0">https://github.com/actions/setup-dotnet/compare/v3...v4.0.0</a></p> <h2>v3.2.0</h2> <h2>What's Changed</h2> <p>In scope of this minor release, the ability to cache the NuGet <code>global-packages</code> folder was added in <a href="https://redirect.github.com/actions/setup-dotnet/pull/303">actions/setup-dotnet#303</a> by <a href="https://github.com/nogic1008"><code>@nogic1008</code></a></p> <p>For caching, the action uses the <a href="https://github.com/actions/toolkit/tree/main/packages/cache"><code>@toolkit/cache</code></a> library under the hood, which in turn allows getting rid of configuring the <a href="https://github.com/actions/cache"><code>@actions/cache</code></a> action separately.</p> <p>Such input parameters as <code>cache</code> and <code>cache-dependency-path</code> were added. The <code>cache</code> input is optional, and caching is turned off by default, <code>cache-dependency-path</code> is used to specify the path to a dependency file - <code>packages.lock.json</code>.</p> <p><strong>Example of use-case:</strong></p> <pre lang="yaml"><code>- uses: actions/setup-dotnet@v3 with: dotnet-version: 6.x cache: true cache-dependency-path: subdir/packages.lock.json </code></pre> <p>More details can be found in the <a href="https://github.com/actions/setup-dotnet#caching-nuget-packages">action's documentation</a>.</p> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/setup-dotnet/compare/v3...v3.2.0">https://github.com/actions/setup-dotnet/compare/v3...v3.2.0</a></p> <h2>v3.1.0</h2> <h2>What's Changed</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/setup-dotnet/commit/6bd8b7f7774af54e05809fcc5431931b3eb1ddee"><code>6bd8b7f</code></a> Bump braces from 3.0.2 to 3.0.3 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/533">#533</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/5d1464d5da459f3d7085106d52e499f4dc5d0f59"><code>5d1464d</code></a> Bump undici from 5.27.2 to 5.28.3 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/515">#515</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/3e6b9fe3930cac7c59c651af5de1514b47a805b9"><code>3e6b9fe</code></a> Update links to runner software (<a href="https://redirect.github.com/actions/setup-dotnet/issues/499">#499</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/769316e2e4f02f2c0567d7990a3f6d9f83b2be98"><code>769316e</code></a> Update README.md to use latest action version (<a href="https://redirect.github.com/actions/setup-dotnet/issues/502">#502</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/4d6c8fcf3c8f7a60068d26b594648e99df24cee3"><code>4d6c8fc</code></a> Upgrade Node to v20 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/484">#484</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/2216f56ae1eec353f06abd464e2ec435fa5f5d43"><code>2216f56</code></a> Update semver (<a href="https://redirect.github.com/actions/setup-dotnet/issues/468">#468</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/736bc6dea68eb71addebd0c89e1200178e145f0e"><code>736bc6d</code></a> Merge pull request <a href="https://redirect.github.com/actions/setup-dotnet/issues/462">#462</a> from akv-platform/update-installers</li> <li><a href="https://github.com/actions/setup-dotnet/commit/f5526c2d1bfe45e0d078b8929dc379a93229ca3b"><code>f5526c2</code></a> Update installers</li> <li><a href="https://github.com/actions/setup-dotnet/commit/4dba25fa3156706981607e1598b263e056dc3008"><code>4dba25f</code></a> Bump word-wrap from 1.2.3 to 1.2.4 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/444">#444</a>)</li> <li><a href="https://github.com/actions/setup-dotnet/commit/ada8800330ab5b086010be13121dd25e9297111e"><code>ada8800</code></a> Bump semver from 6.3.0 to 6.3.1 (<a href="https://redirect.github.com/actions/setup-dotnet/issues/443">#443</a>)</li> <li>Additional commits viewable in <a href="https://github.com/actions/setup-dotnet/compare/v2...v4">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ghom <[email protected]>
) ## About The Pull Request tgstation#86291 added the option to link fishing spots to the fish portal generator, however I did not sprite radial icons for any of them beside a default undescriptive star just to not leave them icon-less. This PR introduces radial icon states for linkable fishing spots and overlays that show on the fish portal gen when selected. A few actually reuse pre-existing icons, like for example chasms and the beach, but most of them are new. To top it off, linked fishing spots show a little star on the top-left of their radial icon to distinguish them from normal portals. ## Why It's Good For The Game Follow-up to my previous PR where I had gotten too lazy to sprite these icon states. Here's how they look in the editor, which is not much different than how they'd look in-game because the radial buttons are more or less that dark too:  ## Changelog :cl: image: added icon states for linkable fishing spots in the fish portal gen radial menu. /:cl:
…ly reduced exp gain from ez pz fishing spots. (tgstation#86776) ## About The Pull Request The fishing skill now improves the casting range of the rod by 1 turf at expert level and 2 at legendary level. It also reduces the delay for reeling objects (not the fishing minigame), which by default is 0.8 seconds, up to 0.3 seconds. Reeling objects also provides a pitiable amount of fishing experience. Fishing on fishing spots with particularly low difficulty compared to the overall skill level now reduces the experience gained. Keep in mind fishing also provides a exp bonus based on difficulty regardless of skill level. This just serves to mitigate the bonus from toilets & co at high level. ## Why It's Good For The Game A good angler should know how to spin the rod and cast the line farther than the average person, and reel in objects faster. ## Changelog :cl: balance: The fishing skill now positively affects fishing rod cast range and reeling objects outside of the minigame. Reeling objects also provides a pitiable amount of fishing experience. balance: High fishing skill now reduces experience gained from low difficulty fishing spots. sound: Removed noise from reeling sounds. /:cl:
## About The Pull Request This PR introduces three new fish that can be caught from deep fryers. That's right, deep fryers are also fishing spots now. Is it silly? Yeah, but this is more or less the reason I made a whole PR to make fish edible. They've two gimmicks: one is that they're already fried, and neither raw nor gorey and can be cut into nuggets. The other is that they can evolve into the next type just by growing, no need of pairing them with each other, starting from the 'fryish', then the 'fritterish' (and its two variants: 'bernard-fish' and 'matthew-fish', big pun on the english food company) and finally the 'nessie-fish' which is very rare and big and you'd probably get 20 nuggets by cutting it alone. Other than that, this PR adds a simple growth mechanic to fish, where they get a bit larger each time they're fed. The gained size and weight depends on several factors like hunger, their current size and weight and how much until they hit the maximum cap of twice the initial size and weight. This means bigger fish grow slowier, and it's better to feed them once in a while but not every other second. Obviously size and weight influence a lot of fish mechanics, so it's good to have a way to increase these values outside of breeding RNG (which is very shallow). TL;DR: Feed the fish once their hunger reaches 50% circa for maximum growth. Included in the PR are a few tidbits, like fixing a little mistake around the 'picky eater' fish trait, more readable code around the fish_growth component (unrelated to the aforementioned growth mechanic) and hunger or adding the fish evolution datum for armored pikes (normal pikes plus stinger trait, which I basically forgot to), and adjusting how weight and size of offsprings is calculated. ## Why It's Good For The Game First and foremost, a brand new on-station fishing spot that is not the fishing portal, toilets (or the rare moisture traps in maint). Second, a fish growth mechanic through which weight and size can be increased. Third, a few code things. Four, little bugs, now fixed. Fifth, have a screenshot of me fucking around to find out how many bites it takes to eat all of the deepfried gargantuan nessie (53, and I had to spawn another 10 humans to finish it):  ## Changelog :cl: add: You can now fish new, tasty treats by the station deep fryers. add: You can now grow fish inside an aquarium by feeding them regularly (at 50% hunger for maximum growth). add: Added the evolution for pikes to armored pikes. /:cl:
…ort (explode into headslug) is innate (tgstation#86605) ## About The Pull Request I've been beating a drum for a little while that Heretic is just Better Changeling, and one of the things that Heretic has that simply blows changeling out of the water is a Get Out of Jail For A Crafted Item card. I took inspiration from that and made the headslug explosion ability for changeling innate. Now they can use it any time they have 20 chemicals. If you want to make sure you're gonna be able to get the ling to the incinerator or a nearby shuttle parking, bait out their abilities, kill them, then set them on fire. Fire stops ling chem regen. Second: Lings aren't really fitting the niche of "Monster That Rapidly Adapts By Consuming Humanoid DNA" very much by being able to readapt once if they've recently killed someone. Instead, I changed it so their readaption is a counter that increments up when they absorb someone. This makes them more adaptable, but it doesn't really increase their strength outside of giving them more ability variety... kinda like Heretic having all their abilities available at all times if they have a focus. I hope this will bring ling more in-line with the other antagonists in the department of Not Sucking in comparison when comparing inherent abilities. ## Why It's Good For The Game Changeling kinda sucks. People have been spamming blood spiders because it is honestly the only viable strategy as a changeling to not get horribly murdered by the valid salad cuisine team extraordinaire. If I'm being totally honest, I'm hoping we can get ling into a place where we can get rid of blood spiders, because I fucking hate how blood spiders work right now, but that's outside the scope of this... This also encourages people to light lings on fire. Fire doesn't prevent headslugging, but if you've managed to outplay the ling into spending all their chemicals before you light their ass up, I think you earned it at that point. Currently, buying headslug is basically trading a power and admitting to yourself "I'm probably gonna fuck up so I'll be less powerful in exchange for this escape route". Instead, just let them explode at their leisure. They already give up every single thing they have on their person when they do this -- ID, weapons, tools, etc -- and they still need to go through the process of finding a corpse to implant in afterward. ## Changelog :cl: Bisar balance: Changelings are now able to respec multiple times if they have absorbed multiple humanoids, instead of it being toggled on if it was off during their most recent absorb. balance: Last Resort is now an innate ability for changelings. code: Added a little counter and a tgui function for displaying how many absorbs lings have in their belly to spend for readaptions! /:cl:
…hacked cigarette vending machines) (tgstation#86098) ## About The Pull Request So, do you remember orbies, those cutesy virtual PDA pets from that PR that Ben made roughly six months ago before moving on his next project, leaving them to be probably forgotten in a near future/present/past? Yeah, personally I never played around, however I recalled that they do have customizable virtual hats, which can be selected from a dropdown in the UI, and I thought that it would be a perfect target for some achievement-related content, as they're totally cosmetic that provides no gameplay advantage nor affects balance in no way whatsoever. I cannot sit well with cheevos being purely an end to itself, that's the reason this PR exists. The new additions to orbies hats, and their respective required achievements are: - The fishing hat (Legendary Fisher) - A huge-ass rollie (Unhealthy Snacks) (yeah, it isn't exactly a hat but the code in no way assume that the item has to be a hat, beside vars named like that for the sake of convenience) - A tape wizard hat (Archmage) - An energy cakehat (Very Important Piscis) - A bounty hunter cowboy hat (Hot Damn!) - A fancy crown (Outdebted) The huge-ass rollie (called fat dart) in the game, is a new cigarette, rarely found in hacked cigarette vending machines. It's obviously a reference to that Ralsei meme from 3 years ago or so but I personally don't care, I just wanted to give an excessively big cigarette to orbies to symbolize the proposterous accomplishment of eating 500 cigarettes in a single round without dying from nicotine OD less than halfway through, but since orbie hats use actual items are references for their appearance, I found myself obliged to add one to the code. Overall, the fat dart comes from an old PR on Citadel, though I had to resprite it myself. Here's a lazy collage of the hats. For some reason unbeknownst to me, the hats are horizontally squished. I need to ask Ben why he did them this way when Orbies' heads are as wide as a rugby ball.  ## Why It's Good For The Game Simple, extra cosmetic stuff for a simple feature that's as relevant as playing around with plushes. ## Changelog :cl: add: Added more customizable options to PDA virtual pets, which can be unlocked by completing achievements. add: Added a fat dart that can be rarely found in hacked cigarette vending machines. /:cl:
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Void conduit has been given slightly less range and the pulse affects only structures within LoS. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game I tested this skill in game a couple of times, it's admittedly a bit overtuned, the pulse ignoring LoS leads to a lot of cheesy scenarios, like RCDing walls all around the portal while being able to space multiple areas. It's still a very good spell, just less insane. <!-- Argue for the merits of your changes and how they benefit the game, especially if they are controversial and/or far reaching. If you can't actually explain WHY what you are doing will improve the game, then it probably isn't good for the game in the first place. --> ## Changelog <!-- If your PR modifies aspects of the game that can be concretely observed by players or admins you should add a changelog. If your change does NOT meet this description, remove this section. Be sure to properly mark your PRs to prevent unnecessary GBP loss. You can read up on GBP and its effects on PRs in the tgstation guides for contributors. Please note that maintainers freely reserve the right to remove and add tags should they deem it appropriate. You can attempt to finagle the system all you want, but it's best to shoot for clear communication right off the bat. --> :cl: balance: Void Conduit has less range and no longer ignores Line of Sight. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
## About The Pull Request Fixes tgstation#72841 Air alarms only check the current gases in the environment. This means that any gas with a minimum threshold will not trigger if it is completely gone from the environment. (like oxygen) ## Why It's Good For The Game Better consistency. ## Changelog :cl: fix: Fix air alarm not checking missing gases /:cl:
…tion#86917) ## About The Pull Request Air alarms had temp/pressure that were hardcoded to be dangerous temps/pressure for humans. This fixes it so that the temp/pressure is based on the settings used in the air alarm. So if a air alarm is ignoring pressure/temp then it doesn't give a warning message. ## Why It's Good For The Game If you want to ignore atmos checks for air alarms in certain areas, then it shouldn't be giving warning messages. ## Changelog :cl: fix: Fix air alarms warning message to use pressure & temp settings /:cl:
## About The Pull Request - Fixes tgstation#86908 ## Changelog :cl: fix: Fixes ethereal APC drain/charge attack /:cl:
…it's actually centered (tgstation#86922) ## About The Pull Request The Infiltrator, in a vacuum of its map file, is facing _NORTH_, the docking port thinks that the shuttle is facing _NORTH_, and the docking port itself is pointed towards _EAST_ (`port_direction = 4`). In times past, this was good and well, the navigation console would properly center the shuttle preview as its offset values dictated. Then the nukie base got a rework. That made it so the shuttle is docked facing _SOUTH_, and since that moves the entire shuttle around, the docking port is now actually facing _WEST_, while still thinking the shuttle is facing _NORTH_, which in turn fucks up `CreateEye()` for the nav console, and the preview is spawned completely off-center. This sucks, this blows, this is awful, please scream at a coder, etc etc. So here's the thing. The ideal solution here is probably actually flipping the shuttle's map file so it's facing _SOUTH_, then adjusting the docking port's vars to account for that and probably adjusting something else in the viscinity. What's done in the first commit here is instead a lazy removal of the offsets' `-` plus a comment. Go me. Anyway, I want some input on those solutions, so here's the PR. ## Why It's Good For The Game Actually centered nukie infiltrator shuttle preview, for once. Wow, that didn't take long at all. Surprisingly no issue opened for this one, but that's more likely because the previews were missing for [a long-ass while](tgstation#62203). Eh, if I find one, I'll close one. ## Changelog :cl: fix: A joint effort of Gorlex Marauders and MI13 tech support teams has finally managed to center the Syndicate Infiltrator shuttle's preview on the navigation console. Nuclear Ops teams sector-wide, rejoice! /:cl:
## About The Pull Request - Adds a coldroom air alarm mapping helper to Meta's medical coldroom so no alerts due to the cold. - Mark coldroom area for kitchen backroom with included APC/Atmos alarm. ## Why It's Good For The Game The atmos to these areas are really cold and will trigger normal atmos alarms so they need special ones. ## Changelog :cl: fix: Fix Meta's medical freezer air alarm to not trigger on cold temps. Fix missing atmos alarm in Wawa kitchen coldroom. /:cl:
## About The Pull Request This pull request does a little bit of cleanup that I came across awhile ago while looking at tgstation#85081, then forgot about, then came back up when I was looking at some additional cleanup that needed to be done. Reorganizes the handle_wave_conclusion function such that it can take a force arg, to force a ore vent to be completed for debug purposes. This also fixes a minor bug where vents, when successfully completed, will still show a warning alert that the waves were failed, and that the vent has closed up. Grammar fix to the examine of boulder processing machines. Moves the can-move behavior of boulders on conveyor belts and during regular stacking to an early return over a late return (Thank you Goofball for pointing that out). Artifact boulders will now default to their artifact icon_state whenever possible. Finally, adds an additional sanity check to boulder processing to check for custom material length, to attempt to avoid zero-content boulders existing and running into the afforementioned tgstation#85081 ## Why It's Good For The Game Largely applies cleanup to several aspects of the boulder processing system, and a handful of (hopefully) performance related rearrangements to the existing layout of boulder processing code. I can't for sure say that it'll fix the linked issue, due to the fact that I could not for some reason re-create the issue in local testing, but I'm hopeful that it's some kind of nebulous sanity-related issue. Cleans up grammar in some spots, and provides a useful debug tool for admin purposes when you just want a vent to flip. Might be a good justification for a ore-manager admin panel later? 🤷 ## Changelog :cl: fix: Artifact boulders should keep their alien icon even after a first round of processing. fix: Boulders are less likely to exist with zero materials after processing. fix: Boulders should be slightly less laggy on conveyor belts. fix: Grammar of refinery/smeltery examine is corrected. /:cl:
## About The Pull Request Just adds the NTNRC client to the pAI digital messenger software's starting programs. To avoid also giving this to the AI, creates a new silicon PDA subtype for pAIs and applies it similarly to borgs. ## Why It's Good For The Game It's already barely ever used, and I just think it'd be fun to let pAIs talk to the never-checked department consoles or open chatrooms with each other or their hosts. Currently you can do this by being in your host's PDA, but this means they couldn't use their PDA at the same time as you just... chatting. Nor could you share a chatroom with them, due to sharing the same account. Also the pAI cabal using the bootleg IRC client to plot their next move is just incredibly funny to me. ## Changelog :cl: balance: The pAI digital messenger software now includes the NTNRC client. /:cl:
…echnically build mode compatible (tgstation#86865)
carpotoxin
requested review from
dawsonkeyes,
SylvetteSylph,
CliffracerX,
Ephemeralis and
kannthus
as code owners
This reverts commit c39cd4f.
Nerev4r
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Brings main up to date with TG's PR.
Why It's Good For The Game
Did you know insulated gloves no longer grant you the 'chunky fingers' trait?