-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ramatae 2: Fixing prefs & sprite names. #124
Ramatae 2: Fixing prefs & sprite names. #124
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't add a new label for the Ramatan tails and ears, instead keep them under lizard tail and lizard ear. The Ramatan tails are function-wise and appearance-wise the same. These labels are not exclusively for easy navigation, they are to give unique organ subtypes to characters. Unique organs that (should) have features, like /obj/item/organ/external/tail/dog
that moodboosts on wag, /obj/item/organ/external/tail/monkey
that grants an internal inventory slot (shared with mouse tails), or /obj/item/organ/external/tail/lizard
that buffs your tackle glove leaps.
Adding onto this list without a solid reason leads to bloating it, even more so when its not a broad category of animal and instead a single race type.
I do not understand grouping these in with lizard ears and tails? The entire purpose of this PR was explicitly to add onto the list, as it fundamentally does not make sense for Ramatan ears and tails to be located under the wrong species tab in the preferences menu, especially when multiple different Anthromorph options without unique mechanics have their own tab, but not this entirely separate species. |
To get a new tab your sprite accessory pool should check off at least one of these:
A species having their own sprite accessories doesn't immediately mean they should have their own tab. |
/shrug. Doesn’t make sense to me, and doesn’t make sense to the labels, but I guess that’s that then. |
Discussed on Discord, converting back to draft to move to bug instead of lizard later. EDIT: Discord discussion once again, will be in a new “Alien” tab. |
its alien time!!!!
sorry i just remembered i shouldnt be able to apply labels anymore lmao |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should ramatan
NOW
About The Pull Request
Renames even more Ramatae files to the correct name. Also moves the preferences for Ramatan ears and Ramatan tails to more accurate menus so the preferences aren't weird anymore.
Why It's Good For The Game
Makes the preference menu much more readable for players trying to make a Ramatan character for the first time who may naively believe their ears are ears.
Changelog
🆑 Sylvette!!
fix: Ramatan ears are no longer horns. Their ears and tails are now in the "Alien" tabs. This bodes well for the Preference menu making sense economy. Also removed that weird "Scug" thing the code kept mentioning for some odd reason.
/:cl: