Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ramatae 2: Fixing prefs & sprite names. #124

Merged

Conversation

SylvetteSylph
Copy link
Collaborator

@SylvetteSylph SylvetteSylph commented Oct 3, 2024

About The Pull Request

Renames even more Ramatae files to the correct name. Also moves the preferences for Ramatan ears and Ramatan tails to more accurate menus so the preferences aren't weird anymore.

image

Why It's Good For The Game

Makes the preference menu much more readable for players trying to make a Ramatan character for the first time who may naively believe their ears are ears.

Changelog

🆑 Sylvette!!
fix: Ramatan ears are no longer horns. Their ears and tails are now in the "Alien" tabs. This bodes well for the Preference menu making sense economy. Also removed that weird "Scug" thing the code kept mentioning for some odd reason.
/:cl:

Copy link
Collaborator

@carpotoxin carpotoxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add a new label for the Ramatan tails and ears, instead keep them under lizard tail and lizard ear. The Ramatan tails are function-wise and appearance-wise the same. These labels are not exclusively for easy navigation, they are to give unique organ subtypes to characters. Unique organs that (should) have features, like /obj/item/organ/external/tail/dog that moodboosts on wag, /obj/item/organ/external/tail/monkey that grants an internal inventory slot (shared with mouse tails), or /obj/item/organ/external/tail/lizard that buffs your tackle glove leaps.
Adding onto this list without a solid reason leads to bloating it, even more so when its not a broad category of animal and instead a single race type.

@SylvetteSylph
Copy link
Collaborator Author

SylvetteSylph commented Oct 3, 2024

Don't add a new label for the Ramatan tails and ears, instead keep them under lizard tail and lizard ear. The Ramatan tails are function-wise and appearance-wise the same. These labels are not exclusively for easy navigation, they are to give unique organ subtypes to characters. Unique organs that (should) have features, like /obj/item/organ/external/tail/dog that moodboosts on wag, /obj/item/organ/external/tail/monkey that grants an internal inventory slot (shared with mouse tails), or /obj/item/organ/external/tail/lizard that buffs your tackle glove leaps. Adding onto this list without a solid reason leads to bloating it, even more so when its not a broad category of animal and instead a single race type.

I do not understand grouping these in with lizard ears and tails? The entire purpose of this PR was explicitly to add onto the list, as it fundamentally does not make sense for Ramatan ears and tails to be located under the wrong species tab in the preferences menu, especially when multiple different Anthromorph options without unique mechanics have their own tab, but not this entirely separate species.

@carpotoxin
Copy link
Collaborator

carpotoxin commented Oct 3, 2024

I do not understand grouping these in with lizard ears and tails? The entire purpose of this PR was explicitly to add onto the list, as it fundamentally does not make sense for Ramatan ears and tails to be located under the wrong species tab in the preferences menu, especially when multiple different Anthromorph options without unique mechanics have their own tab, but not this entirely separate species.

To get a new tab your sprite accessory pool should check off at least one of these:

  • Have sprites that are not similar to an already existing pool
  • Have a feature that separates it from an already existing pool
  • Have a flag like organ_flags = ORGAN_ROBOTIC that separates it from an already existing pool

A species having their own sprite accessories doesn't immediately mean they should have their own tab.
Ramatae sharing the tab with 'lizard' is the same as akula sharing the tab with 'fish'.

@SylvetteSylph
Copy link
Collaborator Author

/shrug. Doesn’t make sense to me, and doesn’t make sense to the labels, but I guess that’s that then.

@SylvetteSylph SylvetteSylph changed the title Ramatae 2: Fixing pref names. [i need help i cant code Help !!!!!!!!] Ramatae 2: Fixing prefs & names. Oct 3, 2024
@SylvetteSylph SylvetteSylph marked this pull request as ready for review October 3, 2024 15:39
@github-actions github-actions bot requested a review from carpotoxin October 3, 2024 15:40
@SylvetteSylph SylvetteSylph changed the title Ramatae 2: Fixing prefs & names. Ramatae 2: Fixing prefs & sprite names. Oct 3, 2024
@SylvetteSylph SylvetteSylph marked this pull request as draft October 3, 2024 16:06
@SylvetteSylph
Copy link
Collaborator Author

SylvetteSylph commented Oct 3, 2024

Discussed on Discord, converting back to draft to move to bug instead of lizard later.

EDIT: Discord discussion once again, will be in a new “Alien” tab.

its alien time!!!!
@SylvetteSylph SylvetteSylph marked this pull request as ready for review October 4, 2024 02:31
@github-actions github-actions bot requested a review from carpotoxin October 4, 2024 02:31
@SylvetteSylph SylvetteSylph added enhancement New feature or request and removed enhancement New feature or request labels Oct 4, 2024
@SylvetteSylph
Copy link
Collaborator Author

sorry i just remembered i shouldnt be able to apply labels anymore lmao

Copy link

@CliffracerX CliffracerX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should ramatan
NOW

@CliffracerX CliffracerX merged commit b51c012 into master Oct 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants