Hearthkin Random Name Gen #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update: we discovered it's randomly calling between the method placed in their language, and an unknown second one. |
MortoSasye
changed the title
MortoSasye
requested review from
CliffracerX,
Ephemeralis and
carpotoxin
as code owners
carpotoxin
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes it so every time you generate a random name with a hearthkin/primitive demihuman char, you'll get lore accurate names.
It alternates between choosing a title or last name, and also checks for feminine, masculine, and neutral names.
Why It's Good For The Game
If I have to see another lore-breaking tribal, I'm going to explod-
Changelog
🆑 MortoSasye
add: Hearthkins now can randomly generate lore-accurate names.
/:cl: