Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Code by Yooriss, I just work here.
This PR introduces basic automatic punctuation for the following circumstances on living mobs only, and only for says (/me or emotes that aren't special say-emotes are unaffected):
To be completely clear: this does not affect PDA's, asterisk emotes (*emotes), full emotes, announcements or basically any other non-speaking form of communication. It affects speech, so says and radio chatter only. PDAspeak enjoyers can continue to sling slang at one another without The Man moderating their grammar.
I've strategically chosen these two changes to produce what I believe to be most comfortable compromise between an easy chatting experience and having dialogue look clean, while also allowing for people to continue to flavour their character's speech patterns as appropriate.
There is one caveat: if you make use of in-game bold/italics/underline formatting, the autopunct function this PR adds will not add an additional end-of-line period if your message does not contain one. For example: |I can't believe you've done this| will not have a period added - you'll need to do this yourself.
I've confirmed with our unofficial TGcode liaison (goof) that regex filters have negligible performance impacts (and that any concerns that they did was largely what he describes as 'cargo cult' behavior). See for yourself on /tg/'s Discord here, if you like.
tl;dr: easier and faster Good Chatting (tm) with likely little performance impact
Why It's Good For The Game
I swear to God.
Changelog
🆑
add: Automatic punctuation!
/:cl: