Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a runtime issue involving character loading and languages. #175

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

00-Steven
Copy link

About The Pull Request

hi yeah i was reading the repo and testing master while waiting for the application and this was getting in the way so-

Anyhow, it seems the occupation and language menus were breaking due to languages runtiming at this line:

var/max_languages = preferences.all_quirks.Find(TRAIT_LINGUIST) ? MAX_LANGUAGES_LINGUIST : MAX_LANGUAGES_NORMAL

Which was due to preferences.all_quirks being null even though it should never be, which I traced back to us using save_data["languages"] where save_data could be null causing load_character(...) to runtime.

Setting it to save_data?["languages"] parallel to all the other save_data calls there seems to fix it just fine!

yep that's a languages menu 👍

Why It's Good For The Game

Fixes runtimes.

Changelog

🆑
fix: Fixed language, occupation, and quirk menu breaking if there is no existing save data.
/:cl:

@carpotoxin carpotoxin merged commit 2c11fe9 into DopplerShift13:master Oct 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants