Fixes a runtime issue involving character loading and languages. #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
hi yeah i was reading the repo and testing master while waiting for the application and this was getting in the way so-
Anyhow, it seems the occupation and language menus were breaking due to languages runtiming at this line:
DopplerShift/modular_doppler/languages/code/language menu/client_languages.dm
Line 68 in c4f78bc
Which was due to
preferences.all_quirks
beingnull
even though it should never be, which I traced back to us usingsave_data["languages"]
wheresave_data
could benull
causingload_character(...)
to runtime.Setting it to
save_data?["languages"]
parallel to all the othersave_data
calls there seems to fix it just fine!yep that's a languages menu 👍
Why It's Good For The Game
Fixes runtimes.
Changelog
🆑
fix: Fixed language, occupation, and quirk menu breaking if there is no existing save data.
/:cl: