Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMI-MODULAR] The Leggening #18

Merged
merged 24 commits into from
Sep 8, 2024

Conversation

CliffracerX
Copy link

About The Pull Request

A twofold PR that tackles two big things - modularizing clothing sprite rendering code to support alternate bodytypes, and the introduction of the official Doppler Shift uniforms, including the drip for command officers.

This also manually mirrors tgstation#85898 and tgstation#85406 since they touch digitigrade legs as such - between the former & the new uniform sprites, the game is already infinitely more playable as a lizard.

Why It's Good For The Game

This is the backbone upon which all species with alternative bodytypes are going to be built & we need nice looking drip for our crew!

Proof of Testing

image
image

Changelog

🆑
add: doppler shift uniforms!
code: refactored clothing rendering to modularly support alternative bodytypes
/:cl:

CliffracerX and others added 4 commits August 29, 2024 14:38
## About The Pull Request

Digitigrade legs use the claw footprint sprite

## Why It's Good For The Game

tgstation#81588 added support for legs to use alternative footprint sprites and
then just didn't add it to anything but monkey legs, even though the
sprites already exist. So let's use them

## Changelog

:cl: Melbert
qol: Xenos and digi lizards have claw footprints 
/:cl:
…on#85406)

Use GAGS to auto-generate digitgrade leg sprites based off of 1 basic
template + color sampling.
Icons are cached relatively aggressively, like female sprite variations.
So no need to worry about that.

The result: All of these sprites with only **3** icons added (the base
template, and the masks)
Obviously it's not perfect - some of the sprites (like the engineer's
jumpsuit) lose some "luster", but it does the job if I do say so myself.

![image](https://github.com/user-attachments/assets/5c23dc97-8716-490c-898c-58b1e01a8a02)

Only applied to undersuits, for now.

- Allows Lizards to show off their handicap, rather than hiding it or
necessitating they use skirts.

- (Ideally) leads to an uptick in Digitigrade abuse (due to being easier
to identify), which is also a net positive.

- Implemented without any common issues revolving alt bodytype clothing
sprites (those being maintainability and sprite bloat)

:cl: Melbert
add: Auto-generated digitigrade clothing sprites for most jumpsuits
/:cl:

---------

Co-authored-by: Ghom <[email protected]>
Custom mantles, berets & hardhats for command staff, alongside our primary custom uniforms.
Awaiting the merge of the GAGS module to implement assistant uniforms.
@CliffracerX
Copy link
Author

CliffracerX commented Aug 30, 2024

This isn't quite ready to go for fullmerge; #13 is blocking since we need our own GAGS folder to support the usual recoloring Assistant uniforms, and I still need to work on pulling in Halcyon's sprites as fallbacks for core game sprites & to allow snouted mask, digitigrade MODsuits, etc.

(That said, it IS ready for testmerge if we want.)

CliffracerX added 5 commits August 29, 2024 23:05
This ports a lot of Halcyon's unfinished work on fitting things to the modern digitigrade legs, this PR wouldn't be possible on such short notice without them.  Additional work coming soon, featuring snouted helmets, and fixing up the original undersuits using Halc's work.
i hate tgstation
@kannthus
Copy link
Member

kannthus commented Sep 2, 2024

image
https://github.com/DopplerShift13/DopplerShift/actions/runs/10637488705/job/29583297493?pr=18

It seems upset about something from the code.

@CliffracerX
Copy link
Author

Not sure what it's having issues with

@Ephemeralis Ephemeralis merged commit 305eef8 into DopplerShift13:master Sep 8, 2024
18 checks passed
Paxilmaniac added a commit that referenced this pull request Oct 29, 2024
maybe fixes day and night in the worst possible way
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants