[NON-MODULAR] Volume mixer #181
Conversation
W4rd3nn
requested review from
CliffracerX,
Ephemeralis and
carpotoxin
as code owners
|
This good for #157 metinks :3 |
There was a problem hiding this comment.
Ok so general preface here. You use way too much triple slash's. When doing comments for edits and the like you should only use double slash as triple slash is used for auto documentation which helps describe functions and variables and how they work and is interpreted by visual studio code. If you are also wanting to do block comments use /* */
Doing so many triple slash's would have royally fucked up autodoc.
Secondly, if you only add / change a singular line, do a inline comment, keep the edit to a singular line as it makes the code significantly easier to maintain as it would help minimize any merge conflicts if there where to be any down the line.
|
ill sign off on these prob tomorrow. busy 2day :3 |
About The Pull Request
So i made a recent PR that changes some of the announcer sounds. Its a lil too loud 4 some people. Rather than going back, tweaking the sounds, and then sending them for review again, I figure I'll just port this closed PR from TG that allows ppl to set a preference for the volumes of certain sounds. This is that PR. Most of the code is courtesy of sadboysuss's PR: tgstation#86932 but I debugged certain parts of it and also added a preference for announcement sounds which is what I wanted in the first place. I also removed the TTS volume part because we dont have that.
Idk how hacky this is and it's certainly not modular so I'd appreciate someone with better knowledge taking a look at it.
Why It's Good For The Game
Earz :3
Changelog
🆑Motho
qol: You can now adjust the volume of certain sound types without outright disabling them.
/:cl: