Implements Bitrunner Prefs Disks (Feat. Quirks & Evil Hacks) #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00-Steven
requested review from
carpotoxin,
Ephemeralis and
Paxilmaniac
as code owners
|
currently this has an issue where the netpod outfit is applied before the loadout, and thus takes precedence over the loadout, which I'm still unsure how to address
|
## About The Pull Request Closes tgstation#87861 Merge skew my beloved ## Changelog :cl: fix: Fixed ayylmao's brain examine lines /:cl:
## About The Pull Request closes tgstation#87330 ## Changelog :cl: grungussuss sound: party popper no longer makes reagent sloshing sounds /:cl:
## About The Pull Request This stops people from using chairs to create free metal. It was possible to pick up a chair or place it down and it would lose it's hologram status since a new object is created. Now anyone that attempts to place down or pick up a chair will have it vanish. ## Why It's Good For The Game No more free metal. ## Changelog :cl: fix: Fix using chairs in holodeck to create infinite metal /:cl:
## About The Pull Request Does as the title says, cleans up the code a bit and modernizes it, as well as making it call its parent. ## Why It's Good For The Game It's more readable this way, plus it properly calls its parent proc now.
## About The Pull Request Stingbangs (and much rarer rotfrags) used their disassembled sprite until primed this entire time. Yeah. ## Why It's Good For The Game Handle appearing out of nowhere looks very jarring
## About The Pull Request Closes tgstation#87809
## About The Pull Request This reduces the bounty size of the crayon civilian pack. Instead of 24 crayons, it only needs 8. Same payout, less quantity. ## Why It's Good For The Game Crayons are not easily produced or scavenged. Even if a map contains 2 full crayon packs in the Library, it still isn't enough to fulfill a single bounty for crayons. This new deal will get you a full payout with a full pack plus one _mystery crayon._ Go rob the clown or detective or something if you need the last one. Get that money!
…t + need boot out for ai to move (tgstation#87726) ## About The Pull Request so there is a problem of: if 2 modsuit modules were to apply the same trait and 1 were removed, shit would break so now all instances of mod_trait applied to the modsuit wearer are refs instead, with mod_trait used for stuff added to items as that isnt likely to have the same thing also qdeleted modsuits delete their parts apparently accidentally removed at some point. the previous time they did it caused qdel loops but this time it doesnt makes boots need to be out for an ai to move someone in a modsuit improves the ui, non-standard cores now have unique colors for the charging bar, and you can extend/retract things from ui, also adds a configurable button to config menu so that the tether doesnt repurpose the pin function made for circuits redoes modsuit balloon alerts to use simpler language makes the weapon recall module make you pick up the weapon if its on your tile as throws dont work on same tile  ## Why It's Good For The Game futureproofing (also technically presentproofing, if you wear something like infiltrator and normal back modsuit and both have ai control they both will give you a trait) also ai movement doesnt have any checks currently, i think it makes sense that it would require your boots to be out so that the ai has something to move fix stuff change break boom wack
## About The Pull Request Includes the map_vote.txt config file created in tgstation#86788 so that it gets read when the server starts. ## Why It's Good For The Game Reads whatever value is set in the config file.
## About The Pull Request fixes tgstation#87844
## About The Pull Request fixes a few runtimes with the meteor heart's sleep behavior, mostly because it was trying to add an element to a blackboard key list, eventhough said key wasnt a list. ## Why It's Good For The Game fixes meteor heart AI runtimes
## About The Pull Request fixes tgstation#87874 also fixes an unintentional sprite change ## Changelog :cl: fix: the manucrafter now properly receives resources, also fixed unintentional manulathe sprite change /:cl:
## About The Pull Request Fixes issues with var typing and proc arguments, discovered using OpenDream's WIP TypeMaker feature (using improvements I haven't PR'd upstream yet). ## Why It's Good For The Game Codebase maintenance.
…gstation#87650) ## About The Pull Request This PR removes the `<B>` and `<br>` from changeling memories since they did not function at all and ruined immersion. * Closes tgstation#84586 Before:  After:  ## Why It's Good For The Game Remove immersion breaking text. ## Changelog :cl: fix: changeling memories of victims no longer include `<B>` and `<br>` /:cl:
Located and removed some space tiles under windows
## About The Pull Request it's purchase path ## Changelog :cl: grungussuss fix: a bug regarding orderable items has been fixed /:cl:
## About The Pull Request moves the crate chaos randomizer marker to the far corner of the domain. this fixes the crate always spawning in one place, somehow. running theory is that the map didn't initialize enough before the crate randomizer was placed, so it never found the encrypted crate so it could never randomize its position. moving it to the corner makes it so it only loads after most of the map does, so it can shuffle the crate around. i tested it  ## Why It's Good For The Game woe, bitrunners must now interact with the map gimmick again ## Changelog :cl: fix: Crate Chaos's encrypted cache is now randomly placed again. /:cl: Co-authored-by: Hatterhat <[email protected]>
…tation#88007) ## About The Pull Request The original PR wasn't ready to merge. Berets need their own masks, otherwise you can see naked scalp poking from underneath them. Will probably PR proper masks a bit later. Closes tgstation#87991 ## Changelog :cl: fix: Berets no longer make you go bald above your earline. /:cl:
…ou how to get it off without water in the description (tgstation#87902) ## About The Pull Request clickable alerts glow (regex: /atom/movable/screen/alert/.*/Click) ## Why It's Good For The Game people are much more likely to look at the chat or anywhere else than the status effect (really, its usually never worth reading 99% of them so they end up ignored) ## Changelog :cl: qol: alerts that do stuff when clicked glow gold /:cl: --------- Co-authored-by: MrMelbert <[email protected]>
…rimtext (tgstation#87994) ## About The Pull Request Title. I may have been wrong about how depended on this behaviour was Also, uh, fixes tgstation#87986 ## Why It's Good For The Game trim_reduced no longer needs to exist because trimtext() does it faster, and there's no reason to have a special proc if trim just calls that proc anyways. I sincerely doubt the proc overhead is so severe that we need another proc that will ever only be called directly 3 times in the code. Since trimtext() does something we don't expect, it's better to just have SDQL2 queries use trim() so we're all on the same page. ## Changelog NO!!!
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Akhter Company Frontier Equipment Sponsorship
…mounts Port over cybernetic limb mounts quirk
…rfirstthought Makes Health Analyzers Work 4 The Blind
…-Thought/update tg update 19NOV24
…tation.git into evilbitrunnerhacks # Conflicts: # modular_doppler/bitrunning_prefs_disks/code/disks/prefs_disk.dm
|
coder rolls world's worst pr update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Implements a new disk that allows bitrunners to select an avatar from their character list to use instead, including all preferences including quirks and optionally loadouts.
This performs evil mock client hacks to allow quirks to be configured, and to have preferences without keeping a reference to the client.
Why It's Good For The Game
Cool bitrunner avatars 👍
Changelog
🆑
add: Bitrunners now spawn with a disk that allows them to select an avatar from their full character list. Taking this into a netpod applies the full character including quirks and optionally loadouts.
add: Bitrunners may now buy additional copies of the disk that allows them to select an avatar for 1000 points each.
/:cl: