Update 27NOV24 #254
Merged
Update 27NOV24 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) ## About The Pull Request - Fixes tgstation#87897 There was an exploit where you can polymorph into the lustrous race and gain the beneficial brain trauma and then polymorph into another race and still keep the trauma. The code was transferring the brain traumas to the new body before it was deleted from the brain. It's now fixed. Special thanks to Melber for coming up with a better solution than the ones I brainstormed. ## Why It's Good For The Game Exploits are bad m'kay. ## Changelog :cl: timothymtorres, MrMelbert fix: Fix lustrous brain trauma not removing during polymorph /:cl:
## About The Pull Request - Fixes tgstation#88001. Pllumbing pill press now reads the maximum volume of the selected product instead of showing a constant of 50u. Patches have a maximum volume of 40u so we send that to the UI - Plumbing pill press now validates the selected container to see if it's a valid printable option to prevent href exploits. It has the same issue as tgstation#87779 but now that's fixed - Plumbing pill press checks to see if the input volume is a number and returns false to stop the UI from updating if not ## Changelog :cl: fix: plumbing pill press advertises the correct maximum volume of your selected product instead of always 50u on the UI code: plumbing pill press validates selected container to prevent href exploits code: plumbing pill press validates input volume to see if it's a number /:cl:
…ion#88023) ## About The Pull Request title ## Why It's Good For The Game it doesn't fit and doesn't make sense ## Changelog :cl: grungussuss sound: the glove pickup sound will no longer play for modsuits undeploying /:cl:
## About The Pull Request the args here are user and set density. we are giving it null and user, no good ## Why It's Good For The Game better ## Changelog
…station#87866) ## About The Pull Request I've been meaning to do this for some time. I need this for portable/handheld aquariums/fishtanks to be possible. I'll sprite and code them before I call this PR ready, however suggestions and code reviews are welcome in the meantime. Being a pretty heavy refactor, some things might break (we have more than a few unit tests so perhaps not) while others, coincidentally, might be fixed without me knowing. Anyway I'm sure this PR fixes aquarium beauty, which wasn't really working to begin with because the code was so fucking bad. Nothing really worth of a CL entry tho. TODO: - [x] handheld aquariums, craftable with a kit and little plastic or buyable from the fun vendor ig. - [x] an aquarium upgrade for handheld aquariums to bypass possible restrictions. - [x] update the beauty element to consider items, which shouldn't contribute to the area beauty when held or otherwise not on a turf. ## Why It's Good For The Game This should make handheld aquariums possible. ## Changelog :cl: refactor: refactored aquariums heavily. Please report any fishy bug. add: Added portable/handheld fish tanks to the game. They can be crafted with an aquarium kit and 5 sheets of plastic. While portable, they cannot store fish that are too big or if there're too many already. This restriction can be removed by using the new "bluespace fish tank kit" techweb item. map: Replaced the lawyer's stationary pet aquarium with a fish tank, so you can carry McGill around. balance: Reduced the iron cost of stationary aquariums a little. /:cl:
…surgery (feat organs sanity fix) (tgstation#87774) ## About The Pull Request This allows you to use a fishing rod during the "manipulate organs" step of the aforementioned surgery to snatch organs from a target. Unlike other fish sources, this one has a negative fishing difficulty of -20, which when summed with the default minigame difficulty should still result in a negative difficulty. In layman terms, this means the minigame is skipped here (unless you're wearing some clunky stuff like insulated or boxing gloves). It also has a wait time of 8 to 13 seconds versus the more random standard 3 to 25 seconds. A small side-effect of this is that explosions during the "manipulate organs" step will basically disembowel you, but it kinda fits anyway. By the by, because of this, there is a tiny chance bluespace fishing rods can yield you random organs. Worry not, they're newly generated, so you won't be snatching it from another player by accident (at least for now). ## Why It's Good For The Game It adds more possible weird and rare shenanigans involving surgery. ## Changelog :cl: Add: You can use a fishing rod to snatch organs during organ manipulation surgery /:cl:
) ## About The Pull Request Added missing updatepaths from tgstation#86084 , which updates floorbots path to repairbots Checked it by applying it, downstream map has correctly changed ## Why It's Good For The Game Easier to apply changes on downstream maps
## About The Pull Request this is a partial rewrite of monkey's attacking behavior ## Why It's Good For The Game closes tgstation#87893 ## Changelog :cl: fix: fixes monkey AI not being able to attack /:cl: --------- Co-authored-by: Ghom <[email protected]>
…tation#87805) ## About The Pull Request * A generic /mob/eye/camera type has been made, containing everything needed to interface with a cameranet * /mob/eye/ai_eye has been refactored into a generic /mob/eye/camera instance * Advanced cameras no longer inherit from AI eyes, splitting off behaviour * Camera code has been somewhat cleaned up * Probably some more stuff I'm forgetting right now ## Big man Southport:  ## Changelog :cl: code: made /proc/getviewsize() pure refactor: mob/eye/ai_eye has been restructured, now inheriting from a generic mob/eye/camera type refactor: advanced cameras and their subtypes are now mob/eye/camera/remote subtypes code: the cameranet no longer expects the user to be an AI eye code: remote camera eyes have had their initialization streamlined code: remote cameras handle assigning and unassigning users by themselves now code: remote cameras now use weakrefs instead of hard referencing owners and origins code: also the sentient disease is_define was removed (we don't have those anymore) fix: AI eyes no longer assign real names to themselves, fixing their orbit name /:cl: --------- Co-authored-by: Ghom <[email protected]>
Co-authored-by: Zephyr <[email protected]>
## About The Pull Request Tin  ## Why It's Good For The Game  ## Changelog :cl: wallem image: Updates slot machine sprites /:cl:
## About The Pull Request So the white cap in loadout isn't very white. In fact it's a cargo cap.   Now it's a white cap. Speaking of loadout someone should add thin prescription glasses to it. Not me though I'm starving for gbp... ## Why It's Good For The Game The loadout shouldn't lie. ## Changelog :cl: fix: Turns Cap (White) into a white cap in loadout /:cl:
## About The Pull Request Closes tgstation#88050 ## Changelog :cl: fix: Fixed incorrect coverage descriptions /:cl:
## About The Pull Request ### comparison: https://github.com/user-attachments/assets/31434a87-231c-4ffa-94b1-440b699c20ef https://github.com/user-attachments/assets/0482062b-b6d0-4b1c-aca1-515a3589179b ## Why It's Good For The Game let's not infringe on copyright ## Changelog :cl: grungussuss sound: the "curse you" sfx has been replaced /:cl:
…gstation#88048) ## About The Pull Request Closes tgstation#83370 Converted most cases where we could benefit from using shared particles (aka when there's probably more than 3 uses of that particle in a round) to use the new shared particle system. Should provide significant clientside performance in particle-heavy areas like botany (or sometimes kitchen) ## Changelog :cl: refactor: Converted most common particle sources to use our new pooling system. /:cl:
## About The Pull Request What is says on the tin. A really simple, though pretty generic looking kitchen utensil sprite for suit storage.  ## Why It's Good For The Game Pink sprites suck. It's so immersion breaking. This resolves that. (why exactly isn't this being caught by unit tests anyway?) ## Changelog :cl: image: Kitchen and eating utensils now have suit storage sprites. /:cl:
|
DNM I'm doing some fuckshit with the tails CI fail |
|
|
Nerev4r
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Updates to tg master as of right now when I write this you can figure it out.
Why It's Good For The Game
👍