forked from tgstation/tgstation
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG detective board #40
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. I'm making a board where a detective can attach various papers and photos that relate to the case he's solving. I made it possible to create cases, attach evidences, remove evidences. But I couldn't make it possible to connect the evidences correctly. My experience in this ended with the fact that the game simply stopped working. That's why I'm asking for help from more experienced developers. Full Preview: https://github.com/user-attachments/assets/f27219bb-4143-46f0-8dd6-1d28cf8876a6 Board on stations: Meta Station: ![meta](https://github.com/user-attachments/assets/ec7fdccd-17a1-40d3-b93b-17425979a6da) Delta Station: Not placed Tram Station: ![Tram](https://github.com/user-attachments/assets/685f342e-fbcf-4e8b-9d7a-8cc8f82db01a) Ice Box Station: ![IceBox](https://github.com/user-attachments/assets/7732a258-ca62-4cc9-8575-3998db545a1d) Wawastation: ![Wawa](https://github.com/user-attachments/assets/c546017d-8f16-4761-b441-cfcf5b8550ad) NorthStar: ![North](https://github.com/user-attachments/assets/4948bcbe-e7d6-4be1-a214-f24f3ff3f334) Birdshot: ![Bird](https://github.com/user-attachments/assets/3b3b0eb4-854b-4998-ad4c-ff53c57194fa) This is good for MRP servers, where detectives can investigate cases just like in the movies :cl: FeudeyTF add: Added board for detective's evidences /:cl: --------- Co-authored-by: Kylerace <[email protected]>
## About The Pull Request Due to the reverse construction, the detective board was placed incorrectly: ![fix1](https://github.com/user-attachments/assets/ac41a76f-873b-4f3e-bf32-d966b135244a) Now its correct. Also if you try attach not paper or photo, you will not recieve messages ## Why It's Good For The Game Fixes ## Changelog :cl: FeudeyTF fix: fixed detective board placing /:cl:
If you switch case, the ropes will stay, untill you reenter in the interface. Now it will change to new case's ropes ☑ If you scroll down with linked evidences, ropes will stay on the screen. Now it will move with evidences ☑ If you try put big content in paper, evidence wil be VERY big. Now max width is 300px ☑ Title will wrap, if it too big. Content of evidence too. ☑ Also i again fixed placement problem, because of wallening revert ☑ Fixes :cl: FeudeyTF fix: fixed an UI problems of evidence board /:cl:
## About The Pull Request If you remove last case, board will crash. Now will not. Also i limited number of cases for 8 cases ## Why It's Good For The Game Fixes ## Changelog :cl: FeudeyTF fix: fixed removing last case /:cl:
This reverts commit 465f69e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑
add: Added new mechanics or gameplay changes
add: Added more things
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
sound: added/modified/removed audio or sound effects
image: added/modified/removed some icons or images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl: