Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roleplay essentials: flavor text & records #64

Merged
merged 14 commits into from
Sep 24, 2024
Merged

Roleplay essentials: flavor text & records #64

merged 14 commits into from
Sep 24, 2024

Conversation

Ephemeralis
Copy link
Collaborator

@Ephemeralis Ephemeralis commented Sep 19, 2024

About The Pull Request

This gets probably the last major feature before version 0 can go live into place: flavour preferences.

It is a mixture of stuff ported from NovaSector and new code.

Notable additions/differences:

  • Flavour text and species information is output in chat versus a new TGUI window. This started off as a concession towards the effort involved in making an entirely new TGUI window design, but then started to gain some aesthetic merit in its own right.
  • Relevant character preferences have been split out into their own Lore page in the character creator. Most of us are used to Nova's way of doing things (aka declaring every new preference as "non-contextual" and shoving it in the same category.
  • Silicon-specific preferences. Cyborgs have their own description and species/model fields, so you can now feasibly play a cyborg character who swaps out into an IPC/synthetic shell mid-round with an entirely unique description that you've written for them. This also includes headshot images.
  • Basic player-written record support. Kind of shitty at the moment but they appear in both security and medical consoles, PDA apps forthcoming. Exploitables are renamed to 'classified records' and guidance is given in the character creation screen about writing interesting ones that aren't just some variant of 'my character has a stash of hardcore pornography involving a particular species of desk fern that they're really bashful about'.
dreamseeker_69x80IMbdk.mp4
dreamseeker_buC6tgmmSB.mp4

In preparation for further customization options linked to preferences later down the line, I've also cut out a PreferenceSingle react element that references a single preference by its chosen savefile key, allowing people who aren't very acquainted with react/typescript (me and the rest of the fucking planet) to create new pages for preferences that aren't wrapped three layers deep in autogenerated wizardry. Mothblocks did an amazing job on the auto-preference stuff, and this gets us the best of both worlds.

Changelog

🆑 yooriss
add: Bespoke in-chat flavour text via examines. Also includes custom species information in a new, separate dialogue!
add: Flavor text, records and other important roleplay-centric character information can now be set via the Lore panel in the character creator.
add: Player-written records are viewable in security and medical records consoles.
code: New PreferenceSingle react element to make creating TGUI interfaces for new preferences significantly easier (where specific sorting/ordering is needed)
/:cl:

@Ephemeralis Ephemeralis marked this pull request as ready for review September 19, 2024 12:40
@Ephemeralis Ephemeralis changed the title [WIP] Roleplay essentials: flavor text & records Roleplay essentials: flavor text & records Sep 19, 2024
Copy link

@CliffracerX CliffracerX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just about ready, just a few things need properly demarkated with doppler edit indicators so it's easier to spot our stuff in future merges.

code/datums/records/manifest.dm Outdated Show resolved Hide resolved
code/datums/records/manifest.dm Outdated Show resolved Hide resolved
code/datums/records/record.dm Outdated Show resolved Hide resolved
code/datums/records/record.dm Outdated Show resolved Hide resolved
code/modules/admin/admin_verbs.dm Outdated Show resolved Hide resolved
tgui/packages/tgui/interfaces/PreferencesMenu/data.ts Outdated Show resolved Hide resolved
@carpotoxin carpotoxin self-requested a review as a code owner September 23, 2024 11:10
@carpotoxin carpotoxin requested review from CliffracerX and removed request for CliffracerX September 23, 2024 11:51
Copy link

@CliffracerX CliffracerX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ready to go now!

@CliffracerX CliffracerX merged commit df021d7 into master Sep 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants