Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Species name in examine is lowercase #95

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

carpotoxin
Copy link
Collaborator

About The Pull Request

Totally a nitpick PR.

image

Why It's Good For The Game

Grammar.

@CliffracerX
Copy link

Would species names not be considered proper(-ish) nouns here? I.E, She is a Thing of Type
I may just be too FromSoft boss nameplate coded with this take

@carpotoxin
Copy link
Collaborator Author

I'm pretty sure this is correct. To prevent confusion, the only part getting lower-case'd is the true species title, not the one the player can customize.

Copy link

@CliffracerX CliffracerX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the edit marker nitpick is resolved, this should be good to go.

code/modules/mob/living/carbon/examine.dm Show resolved Hide resolved
@CliffracerX CliffracerX merged commit ee357e5 into DopplerShift13:master Sep 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants