WiP - MailExtension for Thunderbird

[kewisch]

This would fix #74, at least for Thunderbird 68. There is still some work to do, but I wanted to provide the basics.

I have no idea what the grants are for nor when to request them. The old add-on seemed to do this in the compose window, I'd appreciate to know more. Ideally, the grants could be done in the background without user interaction.

There are some todos left that are basically gruntwork, plus some styling necessary for the management dialog. I've only tested this on beta, so it might need a test drive in 68.1 or later.

That said, I'm not volunteering to maintain this, as I don't use DL.

TODO:

• Add styles to management.css to make the account settings look better
• Don't attempt to get info about the account when it is not yet configured
• File a bug for Thunderbird to provide the compose window as an argument to the composeAction.onClicked listener.
• File a bug for Thunderbird to return compose windows when calling messenger.windows.getLastFocused({ windowTypes: ["messageCompose"] })
• Make debounce function in management.js wait for the promise of the inner func to complete before scheduling a new update
• Make <all_urls> an optional permission and only request host permissions for the URL of the account (not sure if the optional permissions prompt works in Thunderbird, this might need a bug filed)

[kewisch]

Ok I read https://www.thregr.org/~wavexx/software/dl/thunderbird.html and it seems grants are for sending files the other way around. This could be done via composeAction likely, but it should not affect the filelink functionality.

[wavexx]

On Mon, Oct 21 2019, Philipp Kewisch wrote: This would fix #74, at least for Thunderbird 68. There is still some work to do, but I wanted to provide the basics. I have no idea what the grants are for nor when to request them. The old add-on seemed to do this in the compose window, I'd appreciate to know more. Ideally, the grants could be done in the background without user interaction. There are some todos left that are basically gruntwork, plus some styling necessary for the management dialog. I've only tested this on beta, so it might need a test drive in 68.1 or later. That said, I'm not volunteering to maintain this, as I don't use DL. You can view, comment on, or merge this pull request online at: #78

This is great Philipp! I'd ask for feedback from the mailing list, where there were several people waiting for a port. Would you like to make a post a message yourself, or should I do one?

[kewisch]

I've added an update that allows creating grants using an experiment API and filed a bug to fill the missing features. Given I'm likely not going to have time to finish the work soon, I'd appreciate if you could help gather feedback and maybe ask for help.

[reetp]

Huge shout to Philipp for doing this.....

Two questions:
Where do I send the beer tokens? :-)
How can we get his moved forward?

[kewisch]

I've updated the initial comment with a few TODOs. Some of these tasks are pretty easy to do, so maybe someone wants to take a stab at it and I'll incorporate it into the PR. For tokens of gratitude, please donate to a charitable cause, such as SOS-Kinderdörfer. You can also donate to Thunderbird, or send me something.

[reetp]

TODO:

* [ ]   Add styles to `management.css` to make the account settings look better

I may be able to look at this

* [ ]  File a bug for Thunderbird to provide the compose window as an argument to the `composeAction.onClicked` listener.

I can probably add a bug

* [ ]  File a bug for Thunderbird to return compose windows when calling `messenger.windows.getLastFocused({ windowTypes: ["messageCompose"] })`

I can probably add a bug

What I would like to know is first how to build this so I can test it... !

[reetp]

Anything happening here?

Not sure what to do really?

[kewisch]

TODO:

* [ ]   Add styles to `management.css` to make the account settings look better

I may be able to look at this

This would be great! It probably isn't that much necessary and you could make use of some of the browser styles from https://searchfox.org/comm-central/source/mozilla/browser/components/extensions/extension.css

What I would like to know is first how to build this so I can test it... !

IIRC there is no build step. Just go to Debug Add-ons and load the manifest.json as a temporary add-on.

[ghost]

Hello,

I fixed some bugs and adapted the upload code of the files so that the application can run with TB60.*, it works well.

Currently I am working on the compatibility of the module on TB68.*, I come here to ask for a little help.

If porting this extension to TB68.* Interesse someone you will find my modifications here:

https://dl.espci.fr/ticket/584962b680a2b56cb1555ed79c2250ab

[wavexx]

@BilelKharrati wouldn't you like to create a fork and upload the changes via github?

[ghost]

Of course

[ghost]

@wavexx can you submit the new version of DL client for TB60* on addons.thunderbird.net ?

[wavexx]

I invited @gk1220 to join development helping with the Thunderbird addon.
If there is anybody that wishes to help maintaining the TB Addon?

[reetp]

I invited @gk1220 to join development helping with the Thunderbird addon.
If there is anybody that wishes to help maintaining the TB Addon?

I'd be happy to help where I can, but I am no great coder.

Seeing as it was me that kicked up the fuss!

[wavexx]

Any help is welcome. This could range from just testing patches on a current version to TB, to actual code fixes.

[reetp]

Yup. I'll be here......!