Update Fn.concat to compose a function #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That variation is commonly known as Endo. The current one is more of the default behavior for functors - e.g. Maybe(m).concat(Maybe(n)) = Maybe(m.concat(n)) |
|
Ah k. Thanks! More readings required for me. |
|
Nah! Totally got an intuition and nailed the endo instance. It's hard without any types to show contraints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love the series and came on here to clone the spotify example. I saw there was an issue related and thought I'd try to help: #1
The Fn.concat is assuming that the function will return another Fn but it's usage (where fork is just calling the function) highlights that this is probably not intentional. This fix composes the functions together when concatenating.