Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#231 Refactor: 와인 정보/리뷰 보기 수정, WineWishlist 리패키징 #232
base: dev
Are you sure you want to change the base?
#231 Refactor: 와인 정보/리뷰 보기 수정, WineWishlist 리패키징 #232
Changes from all commits
22bef0d
dfef40d
da23806
0c86e1b
d4bb19d
d7e5999
f73b4cd
bcd57db
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional을 사용하는 이유가 nullPointerExceptioin을 방지하기 위해서인데, 조회된 와인 리뷰가 없으면 null값을 반환하는 로직은 적합하지 않아보입니다.
조회되는 와인이 없는경우, 빈 리스트를 반환하도록 변경하는 것이 보안상 좋을것 같습니다.
return recentReviews.orElse(null); 이부분 수정 요청 드립니다.