Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore click events on session header #312

Merged
merged 1 commit into from
Feb 12, 2017
Merged

Ignore click events on session header #312

merged 1 commit into from
Feb 12, 2017

Conversation

tnj
Copy link
Member

@tnj tnj commented Feb 12, 2017

Prevent session cell click event triggered unexpectedly by tapping on header view.

Issue

  • Nothing related

Overview (Required)

  • Just a quick minor UI fix: tapping on the header view of session list causes click event on the cell behind. I don't think that is intended behavior.
  • I just found Stop using twoway-view #180, so this change might be a short life, though.

Links

  • None

Screenshot

Before After

@tnj
Capture click event on session headers
62edc9f 
Prevent session cell click event triggered unexpectedly by tapping on
header view.
@konifar
Copy link
Contributor

konifar commented Feb 12, 2017

👀

@konifar
Copy link
Contributor

konifar commented Feb 12, 2017

Good catch! Thanks!

I just found #180, so this change might be a short life, though.

Yep, but #180 seems difficult. Maybe it will be a long life 😄

@konifar
Copy link
Contributor

konifar commented Feb 12, 2017

LGTM 💯

@tnj
Copy link
Member Author

tnj commented Feb 12, 2017

Wow, superfast review 🚀 Thanks!

@konifar konifar merged commit 5ecc8fe into DroidKaigi:master Feb 12, 2017
@tnj tnj deleted the prevent-tap-behind-header branch February 12, 2017 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnj @konifar