Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark module and setup Baseline Profile generator #719

Open
NUmeroAndDev opened this issue Aug 19, 2023 · 7 comments · May be fixed by #1011
Open

Add benchmark module and setup Baseline Profile generator #719

NUmeroAndDev opened this issue Aug 19, 2023 · 7 comments · May be fixed by #1011
Assignees
@l2hyunwoo
Labels
welcome contribute

Comments

@NUmeroAndDev
Copy link
Collaborator

Idea Description

If we add the benchmark module, we can introduce the baseline profile.
The goal is to add a benchmark module and set up baseline profile generator.

Reference images and links
@l2hyunwoo
Copy link
Contributor

🙋‍♂️

@momomomo111
Copy link
Contributor

@l2hyunwoo Thanks! Assigned!

@takahirom
Copy link
Member

@l2hyunwoo I hope all is going well. Would you have some time to update me on how this issue is progressing?

@l2hyunwoo
Copy link
Contributor

@takahirom Hello, I've already done, but some error delays to complete this issue.

I made baselineprofile module and make success to make baseline-prof.txt when variant is dev. But in case that variant is prod, it occurs error with below message.

Exception thrown during onBeforeAll invocation of plugin com.android.tools.utp.plugins.host.apkinstaller.AndroidTestApkInstallerPlugin.
Failed to install APK: [/Users/hyunwoo/StudioProjects/conference-app-2023/baselineprofile/build/outputs/apk/prod/nonMinifiedRelease/baselineprofile-prod-nonMinifiedRelease.apk] on device emulator-5554.
com.google.testing.platform.core.error.UtpException: ErrorName: Test APK installation Error
NameSpace: AndroidTestApkInstallerPlugin
ErrorCode: 2002
ErrorType: TEST
Message: Failed to install APK: [/Users/hyunwoo/StudioProjects/conference-app-2023/baselineprofile/build/outputs/apk/prod/nonMinifiedRelease/baselineprofile-prod-nonMinifiedRelease.apk] on device emulator-5554.
	at com.android.tools.utp.plugins.host.apkinstaller.AndroidTestApkInstallerPlugin.beforeAll(AndroidTestApkInstallerPlugin.kt:206)
	at com.google.testing.platform.plugin.PluginLifecycle$onBeforeAll$1$2$1$1.invoke(PluginLifecycle.kt:163)
	at com.google.testing.platform.plugin.PluginLifecycle$onBeforeAll$1$2$1$1.invoke(PluginLifecycle.kt:163)
	at com.google.testing.platform.plugin.PluginLifecycle$verify$1.invoke(PluginLifecycle.kt:104)
	at com.google.testing.platform.api.event.Events.verify(Events.kt:31)
	at com.google.testing.platform.plugin.PluginLifecycle.verify(PluginLifecycle.kt:104)
	at com.google.testing.platform.plugin.PluginLifecycle.access$verify(PluginLifecycle.kt:52)
	at com.google.testing.platform.plugin.PluginLifecycle$onBeforeAll$1$2$1.invoke(PluginLifecycle.kt:163)
	at com.google.testing.platform.plugin.PluginLifecycle$onBeforeAll$1$2$1.invoke(PluginLifecycle.kt:162)
	at com.google.testing.platform.plugin.PluginLifecycleKt$invokeOrThrow$1.invoke(PluginLifecycle.kt:374)
	at com.google.testing.platform.plugin.PluginLifecycleKt$invokeOrThrow$1.invoke(PluginLifecycle.kt:374)
	at com.google.testing.platform.core.telemetry.common.noop.NoopDiagnosticsScope.recordEvent(NoopDiagnosticsScope.kt:35)

If you are okay, can you support to find reason of this error? I'll make draft pull request, then test with your local environment with prod variant.

l2hyunwoo added a commit to l2hyunwoo/conference-app-2023 that referenced this issue Aug 29, 2023
@l2hyunwoo
[feature/DroidKaigi#719] Add baselineprofile module
ce9bf0c
l2hyunwoo added a commit to l2hyunwoo/conference-app-2023 that referenced this issue Aug 29, 2023
@l2hyunwoo
[feature/DroidKaigi#719] Add baseline-prof when variant is dev
4350fb3
@l2hyunwoo l2hyunwoo linked a pull request Aug 29, 2023 that will close this issue
Open
l2hyunwoo added a commit to l2hyunwoo/conference-app-2023 that referenced this issue Aug 29, 2023
@l2hyunwoo
[feature/DroidKaigi#719] Delete baseline-prof
824347c
l2hyunwoo added a commit to l2hyunwoo/conference-app-2023 that referenced this issue Aug 29, 2023
@l2hyunwoo
[feature/DroidKaigi#719] Add baselineprofile module
a10b1e1 
[feature/DroidKaigi#719] Add baseline-prof when variant is dev


[feature/DroidKaigi#719] Delete baseline-prof
l2hyunwoo added a commit to l2hyunwoo/conference-app-2023 that referenced this issue Aug 29, 2023
@l2hyunwoo
[feature/DroidKaigi#719] Add baselineprofile module
c9d90ba 
[feature/DroidKaigi#719] Add baseline-prof when variant is dev


[feature/DroidKaigi#719] Delete baseline-prof
@ravenfeld
Copy link

@takahirom Hello, I've already done, but some error delays to complete this issue.

I made baselineprofile module and make success to make baseline-prof.txt when variant is dev. But in case that variant is prod, it occurs error with below message.

Hello, I have the same problem. How did you fix it?

@Subuday
Copy link

Subuday commented Mar 19, 2024

Experience the same problem.

@mahmood199
Copy link

I was facing the same issue.
I had created 2 modules one for benchmark and another for baseline profile.

I had moved all profile generators from baseline module to benchmark module and they work perfectly fine.

l2hyunwoo added a commit to l2hyunwoo/conference-app-2023 that referenced this issue May 27, 2024
@l2hyunwoo
[feature/DroidKaigi#719] Fix local build
6a7a2e3
l2hyunwoo added a commit to l2hyunwoo/conference-app-2023 that referenced this issue May 27, 2024
@l2hyunwoo
[feature/DroidKaigi#719] Add baselineprofile module
3cef2be 
[feature/DroidKaigi#719] Add baseline-prof when variant is dev


[feature/DroidKaigi#719] Delete baseline-prof


[feature/DroidKaigi#719] Fix local build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l2hyunwoo l2hyunwoo

Labels
welcome contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature/#719] Add Benchmark Module and baseline profile generator l2hyunwoo/conference-app-2023
7 participants
@takahirom @ravenfeld @NUmeroAndDev @Subuday @momomomo111 @l2hyunwoo @mahmood199