Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/#719] Add Benchmark Module and baseline profile generator #1011

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[feature/#719] Add Benchmark Module and baseline profile generator #1011

wants to merge 2 commits into from

Conversation

l2hyunwoo
Copy link
Contributor

Issue

Overview (Required)

  • Add Benchmark Module and baseline profile generator
  • There's an issue

@l2hyunwoo l2hyunwoo requested a review from a team as a code owner August 29, 2023 12:36
@l2hyunwoo l2hyunwoo marked this pull request as draft August 29, 2023 12:36
@github-actions
Copy link

github-actions bot commented Aug 29, 2023 •
edited
Loading

Test Results

216 tests   216 ✔️  7m 11s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit cefc3c5.

♻️ This comment has been updated with latest results.

@takahirom takahirom self-requested a review August 29, 2023 15:28
takahirom
takahirom reviewed Aug 29, 2023
View reviewed changes
app-android/src/devRelease/generated/baselineProfiles/baseline-prof.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I'm going to create this by myself without committing so could you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's deleted

@takahirom
Copy link
Member

Let me squash this PR not to enter the baseline prof file 🙏

@l2hyunwoo l2hyunwoo marked this pull request as ready for review August 29, 2023 15:57
@DroidKaigi DroidKaigi deleted a comment from github-actions bot Aug 29, 2023
@takahirom
Copy link
Member

@l2hyunwoo Do you have any idea why this CI takes 1 hour? 👀

@l2hyunwoo
Copy link
Contributor Author

@takahirom It's hard to find the reason why it takes much longer than others..... Reasonable reason that I can think is there's no build cache related to baseline-profile. So if build cache is created, build time will restore I suppose.

+) One more I think is there're procedures that related to prod variant, kind of strange things....(I thought it just assembleDev..) It could increase build time much more
스크린샷 2023-08-31 오후 11 13 32

@takahirom
Copy link
Member

@l2hyunwoo
Well, you can try to use increased build time for the GitHub Action. 🙏

@takahirom takahirom mentioned this pull request Sep 16, 2023
Open
@l2hyunwoo
[feature/DroidKaigi#719] Add baselineprofile module
3cef2be 
[feature/DroidKaigi#719] Add baseline-prof when variant is dev


[feature/DroidKaigi#719] Delete baseline-prof


[feature/DroidKaigi#719] Fix local build
@github-actions GitHub Actions
Copy link

Hi @l2hyunwoo! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions github-actions bot had a problem deploying to deploygate-distribution May 27, 2024 04:12 Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom left review comments

@RyuNen344 RyuNen344 Awaiting requested review from RyuNen344 RyuNen344 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
awesome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add benchmark module and setup Baseline Profile generator
2 participants
@l2hyunwoo @takahirom