Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Fix behavior when search results are Empty. #1002

Merged
merged 1 commit into from
Aug 29, 2023
Merged

🔧 Fix behavior when search results are Empty. #1002

merged 1 commit into from
Aug 29, 2023

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Aug 29, 2023 •
edited
Loading

Issue

Overview (Required)

  • Fix behavior when search results are Empty.
  • Modify to allow re-filtering of category and session type.

Movie (Optional)

Before After
before.mp4
after.mp4

@Corvus400
🔧 Fix behavior when search results are Empty.
4e9b96d 
Modify to allow re-filtering of category and session type.
@Corvus400 Corvus400 requested a review from a team as a code owner August 29, 2023 05:16
@github-actions
Copy link

Test Results

197 tests   197 ✔️  6m 19s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 4e9b96d.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 29, 2023 05:32 Inactive
takahirom
takahirom reviewed Aug 29, 2023
View reviewed changes
.../sessions/src/main/java/io/github/droidkaigi/confsched2023/sessions/SearchScreenViewModel.kt
Comment on lines +74 to +75
searchFilterCategoryUiState = searchFilterCategoryUiState(filters.categories, sessions.categories),
searchFilterSessionTypeUiState = searchFilterSessionTypeUiState(filters.sessionTypes, sessions.sessionTypes),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's better but, if there is a UiState that has all FilterSessionTypeUiStates, we could make this easy 👀

takahirom
takahirom approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@takahirom takahirom merged commit dfc8d6c into DroidKaigi:main Aug 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

@RyuNen344 RyuNen344 Awaiting requested review from RyuNen344 RyuNen344 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't refilter in search view.
2 participants
@Corvus400 @takahirom