Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Privacy Policy depending on the current locale #1042

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Switch Privacy Policy depending on the current locale #1042

merged 2 commits into from
Aug 31, 2023

Conversation

woxtu
Copy link
Contributor

@woxtu woxtu commented Aug 31, 2023

Issue

  • close N/A

Overview (Required)

  • This PR changes to switch Privacy Policy depending on the current locale

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@woxtu woxtu requested a review from a team as a code owner August 31, 2023 16:23
@woxtu woxtu requested a review from momomomo111 August 31, 2023 16:23
@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

Test Results

206 tests   206 ✔️  7m 20s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 1925d3b.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 31, 2023 16:42 Inactive
mhidaka
mhidaka approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@mhidaka mhidaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eagle eyes! this p-r is appropriate advice 🥇

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 31, 2023 19:18 Inactive
@mhidaka mhidaka merged commit 7f82e6e into DroidKaigi:main Aug 31, 2023
8 checks passed
@mhidaka
Copy link
Member

mhidaka commented Aug 31, 2023

@woxtu Thank you for your p-r!

@woxtu woxtu deleted the privacy-policy branch September 1, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhidaka mhidaka mhidaka approved these changes

@momomomo111 momomomo111 Awaiting requested review from momomomo111 momomomo111 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@woxtu @mhidaka