Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] add feature flag handle for stamp #1071

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

ry-itto
Copy link
Member

@ry-itto ry-itto commented Sep 3, 2023

Issue

  • close #ISSUE_NUMBER

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@ry-itto ry-itto requested a review from a team as a code owner September 3, 2023 08:42
import Model

struct RootViewState: ViewModelState {
var isStampEnabled: LoadingState<Bool> = .initial
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nits]
Since we have this ticket #989, it might be better to use the word "achievement" instead.

@ry-itto ry-itto force-pushed the ios-use-feature-flag-for-remote-config branch from 6d505d7 to 4e1377d Compare September 3, 2023 17:57
@ry-itto ry-itto merged commit 611f29c into main Sep 6, 2023
4 checks passed
@ry-itto ry-itto deleted the ios-use-feature-flag-for-remote-config branch September 6, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants