Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract kover configurations into a build-logic plugin #1073

Merged

Conversation

nashcft
Copy link
Contributor

@nashcft nashcft commented Sep 3, 2023

Issue

Overview (Required)

Extracted kover configurations for each projects into a plugin like kotlinx.coroutines' convention plugin so that, when we add a new module, we don't have to care about applying kover plugin to it and adding kover declaration to report-aggregator module.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

N/A

Movie (Optional)

N/A

@nashcft nashcft requested a review from a team as a code owner September 3, 2023 15:30
@nashcft nashcft requested a review from mhidaka September 3, 2023 15:30
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 3, 2023 15:36 Inactive
@github-actions
Copy link

github-actions bot commented Sep 3, 2023

Test Results

211 tests   211 ✔️  6m 26s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit f35f299.

♻️ This comment has been updated with latest results.

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation in this PR is simple and great.
But there may be a tradeoff. This may prevent applying "Project Isolation".

https://gradle.github.io/configuration-cache/#project_isolation

However, there is a document that says we need to wait for the new API. So I would like to introduce this change for now! Thanks for your awesome contribution!

At this stage, we do not recommend that you change your plugin to be somehow "project isolation compatible", as there is no stable definition of what this means yet, nor are all the necessary APIs in place to allow this.

@takahirom
Copy link
Member

Can you fix the conflict? 🙏

@nashcft nashcft force-pushed the extract_kover_configuration_to_plugin branch from a998a7e to f35f299 Compare September 6, 2023 12:49
@nashcft
Copy link
Contributor Author

nashcft commented Sep 6, 2023

Thanks for the review 🙏

Project Isolation

I've read that document and I understand this change will affect project isolation feature in current stage. But the feature is still in experimental, so I also think it should be OK that we use plugins or configurations like this for now 👍

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 6, 2023 13:21 Inactive
@takahirom takahirom merged commit 33d4755 into DroidKaigi:main Sep 7, 2023
@nashcft nashcft deleted the extract_kover_configuration_to_plugin branch September 7, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a single coverage report by KotlinX Cover
2 participants