Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix bottom padding on contributor screen #1107

Merged

Conversation

ked4ma
Copy link
Contributor

@ked4ma ked4ma commented Sep 6, 2023

Issue

  • NO_ISSUE

Overview (Required)

  • As following image(Before), bottom element of contributor will be buried behind the navbar.
    • with some device, snackbar is not displayed due to the navbar.
  • Now, contributor screen is move into about screen
    • so I tried to change padding setting same as staff and sponsor screen to enable to show bottom element and snackbar.
  • This doesn't have an issue ticket, so if it's AWFUL change, please close this PR 🙇

Links

  • nothing

Screenshot (Optional if screenshot test is present or unrelated to UI)

device Before After
Pixel 6 api 30
Pixel Fold api 33

@takahirom
Copy link
Member

Our policy for inset padding is this. Do you have any idea why it doesn't work?
#959 (comment)

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Test Results

211 tests   211 ✔️  8m 45s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 8a19b25.

@ked4ma
Copy link
Contributor Author

ked4ma commented Sep 6, 2023

@takahirom

Our policy for inset padding is this. Do you have any idea why it doesn't work? #959 (comment)

I this it's because ContributorScreen is not in the mainNestedGraph now.
In #959, contentPadding is passed from mainNestedGraph and had been using it for showing ContributorScreen.
But now, this is moved into the KaigiNavHost func.
And this func doesn't have padding information so ContributorScreen will use default PaddingValues .
By default, PaddingValues have 0dp for horizontal and vertical.
As a result, I think how to do padding was changed 🤔

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 6, 2023 13:40 Inactive
@ked4ma ked4ma marked this pull request as ready for review September 7, 2023 01:38
@ked4ma ked4ma requested a review from a team as a code owner September 7, 2023 01:38
@ked4ma ked4ma changed the title [Android] fix bottom padding about contributor screen [Android] fix bottom padding on contributor screen Sep 7, 2023
@takahirom
Copy link
Member

I've checked this approach is used in some screens! Thanks 🙏

@takahirom takahirom merged commit 501faa2 into DroidKaigi:main Sep 7, 2023
8 checks passed
@ked4ma ked4ma deleted the feature/contributor-screen-bottom-padding branch September 8, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants