Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compose Multiplatform] apply theme to contributors screen (w/ workaround) #1108

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[Compose Multiplatform] apply theme to contributors screen (w/ workaround) #1108

merged 1 commit into from
Sep 7, 2023

Conversation

tkhs0604
Copy link
Contributor

@tkhs0604 tkhs0604 commented Sep 6, 2023 •
edited
Loading

Issue

Overview (Required)

  • Apply KaigiTheme to contributions screen for iOS
  • There is an issue that the custom font cannot be read from iOS side, so fixed to return the system font as a workaround 🙏

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

@tkhs0604 tkhs0604 requested a review from a team as a code owner September 6, 2023 17:12
@tkhs0604 tkhs0604 self-assigned this Sep 6, 2023
@tkhs0604 tkhs0604 requested review from upon0426 and a team September 6, 2023 17:12
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 6, 2023 17:16 Inactive
@github-actions
Copy link

github-actions bot commented Sep 6, 2023 •
edited
Loading

Test Results

211 tests   211 ✔️  7m 32s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 7e2ef4f.

♻️ This comment has been updated with latest results.

@tkhs0604 tkhs0604 force-pushed the kenken/apply_theme_to_contributors_screen branch from 5fefde7 to 7e2ef4f Compare September 7, 2023 10:37
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 7, 2023 10:44 Inactive
takahirom
takahirom approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done is better than perfect! Thanks

@takahirom takahirom merged commit 169f2d1 into main Sep 7, 2023
8 checks passed
@takahirom takahirom deleted the kenken/apply_theme_to_contributors_screen branch September 7, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

@upon0426 upon0426 Awaiting requested review from upon0426 upon0426 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees

@tkhs0604 tkhs0604

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tkhs0604 @takahirom