Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Proposal] ♻️ Animate the bookmark button on the session details screen. #1114

Merged
merged 6 commits into from
Sep 8, 2023
Merged

[Proposal] ♻️ Animate the bookmark button on the session details screen. #1114

merged 6 commits into from
Sep 8, 2023

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Sep 7, 2023 •
edited
Loading

Issue

  • None.

Overview (Required)

  • As a test, I tried to animate the bookmark button by AnimatedVectorDrawable only on the session details screen.
  • At first, I wanted to use it on the session list screen as well, but when the bookmark was removed on the bookmark screen, it was displayed as unbookmarked even though it was bookmarked.
  • I could not figure out how to manage the status correctly, so I made it animate only on the detail screen.

Links

Movie (Optional)

API33 API30
animation.mp4

@Corvus400 Corvus400 requested a review from a team as a code owner September 7, 2023 13:36
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Hi @Corvus400! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

Snapshot diff report

File name Image
KaigiAppTest.checkNa
vigateToTimetableIte
mDetailShot_compare.
png
TimetableItemDetailS
creenTest.checkSmall
FontScaleShot_compar
e.png
TimetableItemDetailS
creenTest.checkHugeF
ontScaleShot_compare
.png
TimetableItemDetailS
creenTest.checkReadM
oreExpansionShot_com
pare.png
TimetableItemDetailS
creenTest.checkReadM
oreExpansionShot_2_c
ompare.png
TimetableItemDetailS
creenTest.checkLaunc
hShot_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_2_compare.png
TimetableItemDetailS
creenTest.checkLarge
FontScaleShot_compar
e.png
TimetableItemDetailS
creenTest.checkScrol
lShot_4_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_compare.png
TimetableItemDetailS
creenTest.checkScrol
lShot_3_compare.png
TimetableItemDetailS
creenTest.checkLaunc
hAccessibilityShot_c
ompare.png
TimetableItemDetailS
creenTest.checkBookm
arkToggleShot_compar
e.png

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

Test Results

211 tests   211 ✔️  8m 42s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit cd62912.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 7, 2023 14:20 Inactive
takahirom
takahirom reviewed Sep 7, 2023
View reviewed changes
...ava/io/github/droidkaigi/confsched2023/sessions/component/TimetableItemDetailBottomAppBar.kt Outdated
Icon(
imageVector = Icons.Filled.Bookmark,
contentDescription = SessionsStrings.RemoveFromFavorites.asString(),
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, as far as I know, animated vector drawable was introduced several years ago. So I'm wondering why we need Build.VERSION_CODES.S 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom
Oops sorry, I got my thoughts mixed up with the SplashScreen response. 🙇
It was an unnecessary branch and I removed it!🫡

Copy link
Member

@takahirom takahirom Sep 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to check this before release so could you check if this runs on API Level 23 using Emulator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom
I created an API23 device in the emulator and checked it, and it works fine.🫡
animation_on_api_23
image

@Corvus400
🗑️ Removed unnecessary processing.
262f2e2 
Also, there is no need to put resources in drawable-v31, so that was also removed.
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 7, 2023 16:47 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution September 7, 2023 18:31 Inactive
takahirom
takahirom approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the new animation! 🔖

@takahirom takahirom merged commit 761d195 into DroidKaigi:main Sep 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

@tomoya0x00 tomoya0x00 Awaiting requested review from tomoya0x00 tomoya0x00 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Corvus400 @takahirom