Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty tags may appear in BookmarkList and SearchList (in code) #1133

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Empty tags may appear in BookmarkList and SearchList (in code) #1133

merged 1 commit into from
Sep 9, 2023

Conversation

kkkkan
Copy link
Contributor

@kkkkan kkkkan commented Sep 9, 2023

Issue

Overview (Required)

  • When creating BookmarkList and SearchList tags, we now check that day is not null before creating them.

Links

none

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@kkkkan kkkkan requested a review from a team as a code owner September 9, 2023 10:30
@kkkkan kkkkan requested a review from RyuNen344 September 9, 2023 10:30
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Test Results

215 tests   215 ✔️  6m 46s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit e110c5d.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 9, 2023 10:51 Inactive
takahirom
takahirom approved these changes Sep 9, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks

@takahirom takahirom merged commit c63451d into DroidKaigi:main Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

@RyuNen344 RyuNen344 Awaiting requested review from RyuNen344 RyuNen344 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty tags may appear in BookmarkList and SearchList (in code)
2 participants
@kkkkan @takahirom