-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Added a shell script to create the XCFramework needed when developing the iOS side. #1161
base: main
Are you sure you want to change the base?
✨ Added a shell script to create the XCFramework needed when developing the iOS side. #1161
Conversation
scripts/assemble_xc_framework.sh
Outdated
cd ../ | ||
./gradlew :app-io-shared:assembleSharedReleaseXCFramework | ||
./gradlew :app-io-shared:assembleSharedDebugXCFramework | ||
echo -e "\a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I specified this because I want a sound to be played when the output is completed.
#!/bin/zsh | ||
|
||
cd ../ | ||
./gradlew :app-io-shared:assembleSharedReleaseXCFramework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug alone was not enough, so we also ran the assembleXCFramework in Release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the iOS app currently doesn't use a debug framework so maybe we can remove it?
It is better to be able to use it to streamline the build though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have strong opinion about this but there are a fastlane script to do this. Maybe iOS enginers are familiar with that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any opinion on this? @RyuNen344
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takahirom @RyuNen344 @ry-itto
Our goal is to facilitate iOS development, so of course if there is a better way, we would prefer it.🙌
Issue
Overview (Required)