[Android] add LocalClock to control time for screenshot test #1224

tkhs0604 · 2023-09-15T15:14:52Z

Issue

close Adjusting Time Settings to "Day 1" for Screenshot Tests #1219

Overview (Required)

SSIA
Adding a composition local for clock makes it slightly more adjustable to set datetime information for screenshot test

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before	After

Movie (Optional)

Before	After

github-actions · 2023-09-15T15:36:36Z

Test Results

216 tests 216 ✔️ 8m 25s ⏱️
  11 suites     0 💤
  11 files     0 ❌

Results for commit d41ed3f.

♻️ This comment has been updated with latest results.

kubode

I tried to work on #1219 but was told that the PR is already there.
I commented where I was concerned.

kubode · 2023-09-16T05:53:07Z

...roidMain/kotlin/io/github/droidkaigi/confsched2023/ui/compositionlocal/LocalClockProvider.kt

+import kotlinx.datetime.Clock
+
+@Suppress("CompositionLocalAllowList")
+val LocalClockProvider = compositionLocalOf<Clock> {


IMO, using staticCompositionLocalOf would be better performance.

Thank you for the advice! Let me check the function and replace with it!

tkhs0604 · 2023-09-16T08:09:25Z

Hmm... The format error cannot be resolved even if I suppressed it 🫠...

tkhs0604 · 2023-09-16T08:24:05Z

x: @Suppress("CompositionLocalAllowList")
o: @Suppress("CompositionLocalAllowlist")
😢

github-actions · 2023-09-17T03:28:03Z

Hi @tkhs0604! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

tkhs0604 · 2023-09-17T04:16:28Z

...sting/src/main/java/io/github/droidkaigi/confsched2023/testing/robot/TimetableScreenRobot.kt

-                    onTimetableItemClick = { },
-                    onBookmarkIconClick = { },
-                )
+            CompositionLocalProvider(LocalClock provides FakeClock) {


@takahirom
It does not seem like it works well...
Do you know how I can overwrite the CompositionLocal in test environment? 🤔

Maybe, since there is no setContent in KaigiAppTest, so the only way is to add like ClockTestRule or something like that?

I'm not sure too.
By the way, you might have to fix the commit history 👀

Thank you, I'll investigate the cause again 🙏
And regarding your BTW comment, which commits? All?

Sorry, I might see old commits 🙇

The FakeClock worked well for only TimetableScreenTest on my local, but the screenshot results haven't been updated even if I pushed some commits 👀
Is there any way to update them on this PR's comment?

In case of 2023-09-14T10:00:00.000Z

In case of 2023-09-15T10:00:00.000Z (To check the diff)

I've removed the comment and rerun the test. Let's see what screenshots the tests take.

It seems that there is no change 🎉

Thank you! 🙌

…controll_time_in_preview

takahirom

Thanks!

tkhs0604 self-assigned this Sep 15, 2023

tkhs0604 requested a review from a team as a code owner September 15, 2023 15:14

tkhs0604 requested a review from mhidaka September 15, 2023 15:14

tkhs0604 closed this Sep 15, 2023

tkhs0604 reopened this Sep 16, 2023

tkhs0604 force-pushed the kenken/pass_clock_to_controll_time_in_preview branch from c39834b to 9cbdc1d Compare September 16, 2023 02:37

github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 03:16 Inactive

tkhs0604 force-pushed the kenken/pass_clock_to_controll_time_in_preview branch from bf4a1bc to c8821ac Compare September 16, 2023 05:15

takahirom mentioned this pull request Sep 16, 2023

Adjusting Time Settings to "Day 1" for Screenshot Tests #1219

Closed

github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 05:48 Inactive

kubode reviewed Sep 16, 2023

View reviewed changes

tkhs0604 force-pushed the kenken/pass_clock_to_controll_time_in_preview branch from 34d9afb to ca1ca65 Compare September 16, 2023 08:24

github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 08:52 Inactive

tkhs0604 changed the title ~~[Android] add clock parameter to control time in preview~~ [Android] add LocalClockProvider to control time in preview and test Sep 16, 2023

tkhs0604 changed the title ~~[Android] add LocalClockProvider to control time in preview and test~~ [Android] add LocalClock to control time in preview and test Sep 16, 2023

github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 12:20 Inactive

tkhs0604 force-pushed the kenken/pass_clock_to_controll_time_in_preview branch from 021e82f to 54e8242 Compare September 17, 2023 04:12

tkhs0604 commented Sep 17, 2023

View reviewed changes

github-actions bot temporarily deployed to deploygate-distribution September 17, 2023 04:40 Inactive

tkhs0604 force-pushed the kenken/pass_clock_to_controll_time_in_preview branch from 54e8242 to fb54dac Compare September 17, 2023 05:48

tkhs0604 added 6 commits September 17, 2023 14:48

add clock parameter

d68ca76

add LocalClockProvider

eb10b89

suppress CompositionLocalAllowList

c6787c2

replace with staticCompositionLocalOf

9c90ff8

fix format

518615b

rename to LocalClock

3d0f9c5

tkhs0604 added 2 commits September 17, 2023 14:48

move FakeClock

2172876

fix tests

046fba6

tkhs0604 force-pushed the kenken/pass_clock_to_controll_time_in_preview branch from fb54dac to 046fba6 Compare September 17, 2023 05:49

github-actions bot temporarily deployed to deploygate-distribution September 17, 2023 06:17 Inactive

Merge remote-tracking branch 'origin/main' into kenken/pass_clock_to_…

d456d3f

…controll_time_in_preview

github-actions bot temporarily deployed to deploygate-distribution September 17, 2023 12:54 Inactive

tkhs0604 changed the title ~~[Android] add LocalClock to control time in preview and test~~ [Android] add LocalClock to control time for screenshot test Sep 19, 2023

tkhs0604 added 3 commits September 19, 2023 23:07

inject clock provider

051d5b8

wrap with composition local

c06314b

Merge remote-tracking branch 'origin/main' into kenken/pass_clock_to_…

2a755cc

…controll_time_in_preview

github-actions bot temporarily deployed to deploygate-distribution September 19, 2023 14:46 Inactive

tkhs0604 requested a review from takahirom September 20, 2023 06:57

Merge branch 'main' into kenken/pass_clock_to_controll_time_in_preview

de25d96

github-actions bot temporarily deployed to deploygate-distribution September 24, 2023 06:38 Inactive

DroidKaigi deleted a comment from github-actions bot Sep 30, 2023

Merge branch 'main' into kenken/pass_clock_to_controll_time_in_preview

d41ed3f

github-actions bot temporarily deployed to deploygate-distribution September 30, 2023 08:37 Inactive

takahirom approved these changes Sep 30, 2023

View reviewed changes

takahirom merged commit 9559d15 into main Sep 30, 2023
8 checks passed

takahirom deleted the kenken/pass_clock_to_controll_time_in_preview branch September 30, 2023 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] add LocalClock to control time for screenshot test #1224

[Android] add LocalClock to control time for screenshot test #1224

tkhs0604 commented Sep 15, 2023 •

edited

Loading

github-actions bot commented Sep 15, 2023 •

edited

Loading

kubode left a comment

kubode Sep 16, 2023

tkhs0604 Sep 16, 2023

tkhs0604 commented Sep 16, 2023

tkhs0604 commented Sep 16, 2023

github-actions bot commented Sep 17, 2023

tkhs0604 Sep 17, 2023 •

edited

Loading

takahirom Sep 17, 2023

tkhs0604 Sep 17, 2023

takahirom Sep 17, 2023 •

edited

Loading

tkhs0604 Sep 17, 2023 •

edited

Loading

takahirom Sep 30, 2023 •

edited

Loading

takahirom Sep 30, 2023

tkhs0604 Sep 30, 2023

takahirom left a comment

[Android] add LocalClock to control time for screenshot test #1224

[Android] add LocalClock to control time for screenshot test #1224

Conversation

tkhs0604 commented Sep 15, 2023 • edited Loading

Issue

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Movie (Optional)

github-actions bot commented Sep 15, 2023 • edited Loading

Test Results

kubode left a comment

Choose a reason for hiding this comment

kubode Sep 16, 2023

Choose a reason for hiding this comment

tkhs0604 Sep 16, 2023

Choose a reason for hiding this comment

tkhs0604 commented Sep 16, 2023

tkhs0604 commented Sep 16, 2023

github-actions bot commented Sep 17, 2023

tkhs0604 Sep 17, 2023 • edited Loading

Choose a reason for hiding this comment

takahirom Sep 17, 2023

Choose a reason for hiding this comment

tkhs0604 Sep 17, 2023

Choose a reason for hiding this comment

takahirom Sep 17, 2023 • edited Loading

Choose a reason for hiding this comment

tkhs0604 Sep 17, 2023 • edited Loading

Choose a reason for hiding this comment

takahirom Sep 30, 2023 • edited Loading

Choose a reason for hiding this comment

takahirom Sep 30, 2023

Choose a reason for hiding this comment

tkhs0604 Sep 30, 2023

Choose a reason for hiding this comment

takahirom left a comment

Choose a reason for hiding this comment

tkhs0604 commented Sep 15, 2023 •

edited

Loading

github-actions bot commented Sep 15, 2023 •

edited

Loading

tkhs0604 Sep 17, 2023 •

edited

Loading

takahirom Sep 17, 2023 •

edited

Loading

tkhs0604 Sep 17, 2023 •

edited

Loading

takahirom Sep 30, 2023 •

edited

Loading