Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed because it was crashing when launched from NFC without a network connection #1248

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

kwmt
Copy link

@kwmt kwmt commented Sep 16, 2023

Issue

  • none

Overview (Required)

  • The title is everything.

  • crash log

13:43:01.929  E  FATAL EXCEPTION: main
                 Process: io.github.droidkaigi.confsched2023.dev, PID: 29404
                 java.lang.NullPointerException: Attempt to invoke virtual method 'android.net.Uri com.google.firebase.dynamiclinks.PendingDynamicLinkData.getLink()' on a null object reference
                 	at io.github.droidkaigi.confsched2023.ResolveDynamicLinksActivity$onCreate$1.invoke(ResolveDynamicLinksActivity.kt:20)
                 	at io.github.droidkaigi.confsched2023.ResolveDynamicLinksActivity$onCreate$1.invoke(ResolveDynamicLinksActivity.kt:19)
                 	at io.github.droidkaigi.confsched2023.ResolveDynamicLinksActivity.onCreate$lambda$0(ResolveDynamicLinksActivity.kt:19)
                 	at io.github.droidkaigi.confsched2023.ResolveDynamicLinksActivity.$r8$lambda$H1m2HuA04CiOIgGmadnbjHUIvqo(Unknown Source:0)
                 	at io.github.droidkaigi.confsched2023.ResolveDynamicLinksActivity$$ExternalSyntheticLambda0.onSuccess(Unknown Source:2)
                 	at com.google.android.gms.tasks.zzm.run(com.google.android.gms:play-services-tasks@@18.0.2:1)
                 	at android.os.Handler.handleCallback(Handler.java:942)
                 	at android.os.Handler.dispatchMessage(Handler.java:99)
                 	at android.os.Looper.loopOnce(Looper.java:201)
                 	at android.os.Looper.loop(Looper.java:288)
                 	at android.app.ActivityThread.main(ActivityThread.java:7872)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Links

Movie

Before After
Screen_recording_20230916_134305.mp4
Screen_recording_20230916_134205.mp4

@kwmt kwmt marked this pull request as ready for review September 16, 2023 04:46
@kwmt kwmt requested a review from a team as a code owner September 16, 2023 04:46
@kwmt kwmt requested a review from tkhs0604 September 16, 2023 04:46
@github-actions
Copy link

Hi @kwmt! Codes seem to be unformatted. To resolve this issue, please run ./gradlew detekt --auto-correct and fix the results of ./gradlew lintDebug.. Thank you for your contribution.

@github-actions
Copy link

Test Results

215 tests   215 ✔️  8m 22s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit e0da208.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 05:06 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the debug!

@takahirom takahirom merged commit b97f9b7 into DroidKaigi:main Sep 16, 2023
8 checks passed
@kwmt kwmt deleted the fix/start-from-deeplink branch September 16, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants