Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checkLaunchServerErrorShot #1255

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Add checkLaunchServerErrorShot #1255

merged 4 commits into from
Sep 18, 2023

Conversation

Oxypetalum7
Copy link
Contributor

@Oxypetalum7 Oxypetalum7 commented Sep 16, 2023 •
edited
Loading

Issue

Overview (Required)

  • Add StaffScreenTest#checkLaunchServerErrorShot()
    • Add sessionsApiClient, fakeSessionsApiClient , ServerStatusEnum, setupServer() at StaffScreenRobot

@Oxypetalum7 Oxypetalum7 marked this pull request as ready for review September 16, 2023 05:55
@Oxypetalum7 Oxypetalum7 requested a review from a team as a code owner September 16, 2023 05:55
@Oxypetalum7 Oxypetalum7 changed the title Feature/add check launch server error shot Add checkLaunchServerErrorShot Sep 16, 2023
takahirom
takahirom approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@github-actions
Copy link

Snapshot diff report

File name Image
StaffScreenTest.chec
kLaunchServerErrorSh
ot_compare.png

@github-actions
Copy link

github-actions bot commented Sep 16, 2023 •
edited
Loading

Test Results

216 tests   216 ✔️  8m 37s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit f963881.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 06:24 Inactive
takahirom
takahirom reviewed Sep 16, 2023
View reviewed changes
core/testing/src/main/java/io/github/droidkaigi/confsched2023/testing/robot/StaffScreenRobot.kt Outdated
@@ -16,6 +18,10 @@ class StaffScreenRobot @Inject constructor(
) {

@Inject lateinit var robotTestRule: RobotTestRule

@Inject lateinit var sessionsApiClient: SessionsApiClient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It seems that we should use StaffApi for this 🙇

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takahirom
Sorry for the delay in contribution 🙇
I fixed it.
:fix: change to staffApiClient

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 17, 2023 07:47 Inactive
@takahirom takahirom merged commit 2052094 into DroidKaigi:main Sep 18, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upon0426 upon0426 Awaiting requested review from upon0426 upon0426 is a code owner automatically assigned from DroidKaigi/conferenceapp2023reviewer

@takahirom takahirom Awaiting requested review from takahirom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add StaffScreenTest.checkLaunchServerErrorShot()
2 participants
@Oxypetalum7 @takahirom