Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit API for core/data module #1257

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Use explicit API for core/data module #1257

merged 3 commits into from
Sep 16, 2023

Conversation

tatsutakein
Copy link
Member

Issue

Overview (Required)

  • Explicitly specify access modifiers for core-data modules to the minimum required public scope.

Links

@tatsutakein tatsutakein self-assigned this Sep 16, 2023
@tatsutakein tatsutakein requested a review from a team as a code owner September 16, 2023 06:06
@github-actions
Copy link

Test Results

215 tests   215 ✔️  11m 6s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit 89acc5b.

takahirom
takahirom approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 06:39 Inactive
@takahirom takahirom merged commit 7c5da28 into DroidKaigi:main Sep 16, 2023
8 checks passed
@tatsutakein tatsutakein deleted the use-explicitApi-for-core-data branch September 16, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees

@tatsutakein tatsutakein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use explicit API for core/data module
2 participants
@tatsutakein @takahirom