Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change lineHeight of session tag #1261

Merged
merged 3 commits into from
Sep 16, 2023

Conversation

hiroaki404
Copy link
Contributor

@hiroaki404 hiroaki404 commented Sep 16, 2023

Issue

Overview (Required)

  • The session tag's height was too large, so I reduced it by specifying a fixed value for lineHeight. I changed it to apply the 'label-medium' in the Material Theme.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@hiroaki404 hiroaki404 requested a review from a team as a code owner September 16, 2023 09:25
@github-actions
Copy link

github-actions bot commented Sep 16, 2023

Snapshot diff report

File name Image
SearchScreenTest.che
ckFilterLanguageChip
Shot_compare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay1AndDay3Shot_co
mpare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay1AndDay2Shot_co
mpare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_compare.png
SearchScreenTest.che
ckFilterDayChipShot_
2_compare.png
BookmarkScreenTest.c
heckBookmarkFilterCh
ipDay1Shot_compare.p
ng
TimetableScreenTest.
checkHugeFontScaleSh
ot_compare.png
SearchScreenTest.che
ckFilterSessionTypeC
hipShot_compare.png
SearchScreenTest.che
ckFilterLanguageChip
Shot_2_compare.png
SearchScreenTest.che
ckLaunchShot_compare
.png
SearchScreenTest.che
ckLargeFontScaleShot
_compare.png
SearchScreenTest.che
ckFilterLanguageChip
Shot_3_compare.png
TimetableScreenTest.
checkSmallFontScaleS
hot_compare.png
TimetableScreenTest.
checkScrollShot_comp
are.png
TimetableScreenTest.
checkLargeFontScaleS
hot_compare.png
SearchScreenTest.che
ckFilterDayChipShot_
3_compare.png
SearchScreenTest.che
ckHugeFontScaleShot_
compare.png
SearchScreenTest.che
ckFilterDayChipShot_
compare.png
TimetableScreenTest.
checkLaunchShot_comp
are.png
SearchScreenTest.che
ckFilterSessionTypeC
hipShot_3_compare.pn
g
SearchScreenTest.che
ckSmallFontScaleShot
_compare.png
SearchScreenTest.che
ckFilterSessionTypeC
hipShot_2_compare.pn
g
SearchScreenTest.che
ckFilterCategoryChip
Shot_compare.png
TimetableScreenTest.
checkBookmarkToggleS
hot_2_compare.png
SearchScreenTest.che
ckFilterCategoryChip
Shot_2_compare.png
SearchScreenTest.che
ckFilterCategoryChip
Shot_3_compare.png
BookmarkScreenTest.c
heckLaunchNotEmptySh
ot_compare.png
KaigiAppTest.checkSt
artupShot_compare.pn
g
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_SessionTagPrevi
ew-LightMode-10_10_n
ull_compare.png
KaigiAppTest.checkTi
metableTabs_2_compar
e.png
KaigiAppTest.checkTi
metableTabs_compare.
png
io.github.droidkaigi
.confsched2023.sessi
ons.component_null_T
heme_SessionTagPrevi
ew-DarkMode-10_11_nu
ll_compare.png
KaigiAppTest.checkMe
diumTabletLaunchShot
_compare.png
KaigiAppTest.checkTi
metableTabs_3_compar
e.png

@github-actions
Copy link

github-actions bot commented Sep 16, 2023

Test Results

215 tests   215 ✔️  8m 14s ⏱️
  11 suites      0 💤
  11 files        0

Results for commit 38e8aab.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 09:53 Inactive
@hiroaki404
Copy link
Contributor Author

I changed it to apply the 'label-medium' in the Material Theme.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 10:49 Inactive
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@takahirom takahirom merged commit 0a8bd1d into DroidKaigi:main Sep 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix chip height
2 participants